From: "Darrick J. Wong" <djwong@kernel.org>
To: guaneryu@gmail.com, Catherine Hoang <catherine.hoang@oracle.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 1/2] xfs/019: fix golden output for files created in setgid dir
Date: Tue, 19 Apr 2022 11:38:55 -0700 [thread overview]
Message-ID: <20220419183855.GO17025@magnolia> (raw)
In-Reply-To: <20220419183347.hruyn5zimz6tcxd4@zlang-mailbox>
On Wed, Apr 20, 2022 at 02:33:47AM +0800, Zorro Lang wrote:
> On Tue, Apr 19, 2022 at 10:32:00AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > A recent change to xfs/019 exposed a long-standing bug in mkfs where
> > it would always set the gid of a new child created in a setgid directory
> > to match the gid parent directory instead of what's in the protofile.
> >
> > Ignoring the user's directions is not the correct behavior, so update
> > this test to reflect that. Also don't erase the $seqres.full file,
> > because that makes forensic analysis pointlessly difficult.
> >
> > Cc: Catherine Hoang <catherine.hoang@oracle.com>
> > Fixes: 7834a740 ("xfs/019: extend protofile test")
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
>
> After merge this patch, xfs/019 fails on my system. So this test will cover
> a new bug of xfsprogs which hasn't been fixed? If so, this change is good to me.
> But we'd better to take a look at the patch you used to fix xfsprogs, and make
> sure it's reviewed.
Yep. Already reviewed, just waiting for xfsprogs 5.15.1:
https://lore.kernel.org/linux-xfs/B28D1D24-2E23-4F60-AA50-C199392BBE4F@oracle.com/T/#u
--D
>
> Thanks,
> Zorro
>
> > tests/xfs/019 | 3 +--
> > tests/xfs/019.out | 2 +-
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
> >
> > diff --git a/tests/xfs/019 b/tests/xfs/019
> > index 535b7af1..790a6821 100755
> > --- a/tests/xfs/019
> > +++ b/tests/xfs/019
> > @@ -10,6 +10,7 @@
> > _begin_fstest mkfs auto quick
> >
> > seqfull="$seqres.full"
> > +rm -f $seqfull
> > # Import common functions.
> > . ./common/filter
> >
> > @@ -97,7 +98,6 @@ _verify_fs()
> > echo "*** create FS version $1"
> > VERSION="-n version=$1"
> >
> > - rm -f $seqfull
> > _scratch_unmount >/dev/null 2>&1
> >
> > _full "mkfs"
> > @@ -131,6 +131,5 @@ _verify_fs()
> > _verify_fs 2
> >
> > echo "*** done"
> > -rm $seqfull
> > status=0
> > exit
> > diff --git a/tests/xfs/019.out b/tests/xfs/019.out
> > index 8584f593..9db157f9 100644
> > --- a/tests/xfs/019.out
> > +++ b/tests/xfs/019.out
> > @@ -61,7 +61,7 @@ Device: <DEVICE> Inode: <INODE> Links: 2
> >
> > File: "./directory_setgid/file_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx_5"
> > Size: 5 Filetype: Regular File
> > - Mode: (0755/-rwxr-xr-x) Uid: (3) Gid: (2)
> > + Mode: (0755/-rwxr-xr-x) Uid: (3) Gid: (1)
> > Device: <DEVICE> Inode: <INODE> Links: 1
> >
> > File: "./pipe"
> >
>
next prev parent reply other threads:[~2022-04-19 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 17:31 [PATCHSET 0/2] fstests: random fixes Darrick J. Wong
2022-04-19 17:32 ` [PATCH 1/2] xfs/019: fix golden output for files created in setgid dir Darrick J. Wong
2022-04-19 18:33 ` Zorro Lang
2022-04-19 18:38 ` Darrick J. Wong [this message]
2022-04-20 14:47 ` Zorro Lang
2022-04-20 16:03 ` Catherine Hoang
2022-04-19 17:32 ` [PATCH 2/2] generic/019: fix incorrect unset statements Darrick J. Wong
2022-04-19 18:34 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419183855.GO17025@magnolia \
--to=djwong@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).