linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: standardize GFP flags usage in online scrub
Date: Fri, 14 Oct 2022 09:38:31 +1100	[thread overview]
Message-ID: <20221013223831.GC3600936@dread.disaster.area> (raw)
In-Reply-To: <166473479206.1083296.4351345740736162376.stgit@magnolia>

On Sun, Oct 02, 2022 at 11:19:52AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Memory allocation usage is the same throughout online fsck -- we want
> kernel memory, we have to be able to back out if we can't allocate
> memory, and we don't want to spray dmesg with memory allocation failure
> reports.  Standardize the GFP flag usage and document these requirements.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

      reply	other threads:[~2022-10-13 22:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 18:19 [PATCHSET v23.1 0/2] xfs: clean up memory allocations in online fsck Darrick J. Wong
2022-10-02 18:19 ` [PATCH 2/2] xfs: pivot online scrub away from kmem.[ch] Darrick J. Wong
2022-10-13 22:42   ` Dave Chinner
2022-10-13 22:50     ` Darrick J. Wong
2022-10-02 18:19 ` [PATCH 1/2] xfs: standardize GFP flags usage in online scrub Darrick J. Wong
2022-10-13 22:38   ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221013223831.GC3600936@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).