From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 547BEC433FE for ; Fri, 14 Oct 2022 05:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229518AbiJNFHS (ORCPT ); Fri, 14 Oct 2022 01:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiJNFHR (ORCPT ); Fri, 14 Oct 2022 01:07:17 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 967E31946F1 for ; Thu, 13 Oct 2022 22:07:15 -0700 (PDT) Received: from dread.disaster.area (pa49-181-106-210.pa.nsw.optusnet.com.au [49.181.106.210]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id D06BA1101B70; Fri, 14 Oct 2022 16:07:14 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ojCug-001l8X-9y; Fri, 14 Oct 2022 16:07:14 +1100 Date: Fri, 14 Oct 2022 16:07:14 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/6] xfs: block map scrub should handle incore delalloc reservations Message-ID: <20221014050714.GP3600936@dread.disaster.area> References: <166473480864.1083927.11062319917293302327.stgit@magnolia> <166473480915.1083927.736458976932286147.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166473480915.1083927.736458976932286147.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=OJNEYQWB c=1 sm=1 tr=0 ts=6348ee82 a=j6JUzzrSC7wlfFge/rmVbg==:117 a=j6JUzzrSC7wlfFge/rmVbg==:17 a=kj9zAlcOel0A:10 a=Qawa6l4ZSaYA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=UFsqSS1z8YH85jcf9OYA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Oct 02, 2022 at 11:20:09AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Enhance the block map scrubber to check delayed allocation reservations. > Though there are no physical space allocations to check, we do need to > make sure that the range of file offsets being mapped are correct, and > to bump the lastoff cursor so that key order checking works correctly. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/scrub/bmap.c | 55 +++++++++++++++++++++++++++++++++------------------ > 1 file changed, 36 insertions(+), 19 deletions(-) Seems reasonable to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com