linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chandan Babu R <chandanrlinux@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfstest: test fallocate ops when rt extent size is and isn't a power of 2
Date: Tue, 20 Oct 2020 10:30:12 +0530	[thread overview]
Message-ID: <2454211.VvKRWnKNI2@garuda> (raw)
In-Reply-To: <20201017215158.GH9832@magnolia>

On Sunday 18 October 2020 3:21:58 AM IST Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Make sure that fallocate works when the rt extent size is and isn't a
> power of 2.

The changes look good to me.

Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>

> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/xfs/763     |  152 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/763.out |   55 +++++++++++++++++++
>  tests/xfs/group   |    1 
>  3 files changed, 208 insertions(+)
>  create mode 100755 tests/xfs/763
>  create mode 100644 tests/xfs/763.out
> 
> diff --git a/tests/xfs/763 b/tests/xfs/763
> new file mode 100755
> index 00000000..a4351bd9
> --- /dev/null
> +++ b/tests/xfs/763
> @@ -0,0 +1,152 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) 2020, Oracle and/or its affiliates.  All Rights Reserved.
> +#
> +# FS QA Test No. 763
> +#
> +# Make sure that regular fallocate functions work ok when the realtime extent
> +# size is and isn't a power of 2.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1    # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +	cd /
> +	_scratch_unmount >> $seqres.full 2>&1
> +	test -e "$rtdev" && losetup -d $rtdev >> $seqres.full 2>&1
> +	rm -f $tmp.* $TEST_DIR/$seq.rtvol
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_require_xfs_io_command "fpunch"
> +_require_xfs_io_command "fzero"
> +_require_xfs_io_command "fcollapse"
> +_require_xfs_io_command "finsert"
> +# Note that we don't _require_realtime because we synthesize a rt volume
> +# below.  This also means we cannot run the post-test check.
> +_require_scratch_nocheck
> +
> +log() {
> +	echo "$@" | tee -a $seqres.full
> +}
> +
> +mk_file() {
> +	local file="$1"
> +	local rextsize="$2"
> +
> +	$XFS_IO_PROG -f \
> +		-c "pwrite -S 0x57 -b $rextsize 0 $rextsize" \
> +		-c "pwrite -S 0x58 -b $rextsize $rextsize $rextsize" \
> +		-c "pwrite -S 0x59 -b $rextsize $((rextsize * 2)) $rextsize" \
> +		-c fsync \
> +		"$file" >> $seqres.full
> +}
> +
> +check_file() {
> +	filefrag -v "$1" >> $seqres.full
> +	od -tx1 -Ad -c "$1" >> $seqres.full
> +	md5sum "$1" | _filter_scratch | tee -a $seqres.full
> +}
> +
> +test_ops() {
> +	local rextsize=$1
> +	local unaligned_sz=65536
> +	local sz=$((rextsize * 3))
> +
> +	log "Format rtextsize=$rextsize"
> +	_scratch_unmount
> +	_scratch_mkfs -r extsize=$rextsize >> $seqres.full
> +	_scratch_mount || \
> +		_notrun "Could not mount rextsize=$rextsize with synthetic rt volume"
> +
> +	# Force all files to be realtime files
> +	$XFS_IO_PROG -c 'chattr +t' $SCRATCH_MNT
> +
> +	log "Test regular write, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/write $rextsize
> +	check_file $SCRATCH_MNT/write
> +
> +	log "Test aligned falloc, rextsize=$rextsize"
> +	$XFS_IO_PROG -f -c "falloc 0 $sz" $SCRATCH_MNT/falloc >> $seqres.full
> +	check_file $SCRATCH_MNT/falloc
> +
> +	log "Test aligned fcollapse, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/collapse $rextsize
> +	$XFS_IO_PROG -f -c "fcollapse $rextsize $rextsize" $SCRATCH_MNT/collapse >> $seqres.full
> +	check_file $SCRATCH_MNT/collapse
> +
> +	log "Test aligned finsert, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/insert $rextsize
> +	$XFS_IO_PROG -f -c "finsert $rextsize $rextsize" $SCRATCH_MNT/insert >> $seqres.full
> +	check_file $SCRATCH_MNT/insert
> +
> +	log "Test aligned fzero, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/zero $rextsize
> +	$XFS_IO_PROG -f -c "fzero $rextsize $rextsize" $SCRATCH_MNT/zero >> $seqres.full
> +	check_file $SCRATCH_MNT/zero
> +
> +	log "Test aligned fpunch, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/punch $rextsize
> +	$XFS_IO_PROG -f -c "fpunch $rextsize $rextsize" $SCRATCH_MNT/punch >> $seqres.full
> +	check_file $SCRATCH_MNT/punch
> +
> +	log "Test unaligned falloc, rextsize=$rextsize"
> +	$XFS_IO_PROG -f -c "falloc $unaligned_sz $unaligned_sz" $SCRATCH_MNT/ufalloc >> $seqres.full
> +	check_file $SCRATCH_MNT/ufalloc
> +
> +	log "Test unaligned fcollapse, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/ucollapse $rextsize
> +	$XFS_IO_PROG -f -c "fcollapse $unaligned_sz $unaligned_sz" $SCRATCH_MNT/ucollapse >> $seqres.full
> +	check_file $SCRATCH_MNT/ucollapse
> +
> +	log "Test unaligned finsert, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/uinsert $rextsize
> +	$XFS_IO_PROG -f -c "finsert $unaligned_sz $unaligned_sz" $SCRATCH_MNT/uinsert >> $seqres.full
> +	check_file $SCRATCH_MNT/uinsert
> +
> +	log "Test unaligned fzero, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/uzero $rextsize
> +	$XFS_IO_PROG -f -c "fzero $unaligned_sz $unaligned_sz" $SCRATCH_MNT/uzero >> $seqres.full
> +	check_file $SCRATCH_MNT/uzero
> +
> +	log "Test unaligned fpunch, rextsize=$rextsize"
> +	mk_file $SCRATCH_MNT/upunch $rextsize
> +	$XFS_IO_PROG -f -c "fpunch $unaligned_sz $unaligned_sz" $SCRATCH_MNT/upunch >> $seqres.full
> +	check_file $SCRATCH_MNT/upunch
> +
> +	log "Check everything, rextsize=$rextsize"
> +	_check_scratch_fs
> +}
> +
> +echo "Create fake rt volume"
> +truncate -s 400m $TEST_DIR/$seq.rtvol
> +rtdev=$(_create_loop_device $TEST_DIR/$seq.rtvol)
> +
> +echo "Make sure synth rt volume works"
> +export USE_EXTERNAL=yes
> +export SCRATCH_RTDEV=$rtdev
> +_scratch_mkfs > $seqres.full
> +_scratch_mount || \
> +	_notrun "Could not mount with synthetic rt volume"
> +
> +# power of two
> +test_ops 262144
> +
> +# not a power of two
> +test_ops 327680
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/xfs/763.out b/tests/xfs/763.out
> new file mode 100644
> index 00000000..b6633fd2
> --- /dev/null
> +++ b/tests/xfs/763.out
> @@ -0,0 +1,55 @@
> +QA output created by 763
> +Create fake rt volume
> +Make sure synth rt volume works
> +Format rtextsize=262144
> +Test regular write, rextsize=262144
> +2dce060217cb2293dde96f7fdb3b9232  SCRATCH_MNT/write
> +Test aligned falloc, rextsize=262144
> +cb18a5d28e77522dfec6a6255bc3847e  SCRATCH_MNT/falloc
> +Test aligned fcollapse, rextsize=262144
> +2e94746ab733025c21a9cae7d19c18d0  SCRATCH_MNT/collapse
> +Test aligned finsert, rextsize=262144
> +24e228d3d5f68b612eceec47f8416a7d  SCRATCH_MNT/insert
> +Test aligned fzero, rextsize=262144
> +ecb6eb78ceb5c43ce86d523437b1fa95  SCRATCH_MNT/zero
> +Test aligned fpunch, rextsize=262144
> +ecb6eb78ceb5c43ce86d523437b1fa95  SCRATCH_MNT/punch
> +Test unaligned falloc, rextsize=262144
> +0dfbe8aa4c20b52e1b8bf3cb6cbdf193  SCRATCH_MNT/ufalloc
> +Test unaligned fcollapse, rextsize=262144
> +fallocate: Invalid argument
> +2dce060217cb2293dde96f7fdb3b9232  SCRATCH_MNT/ucollapse
> +Test unaligned finsert, rextsize=262144
> +fallocate: Invalid argument
> +2dce060217cb2293dde96f7fdb3b9232  SCRATCH_MNT/uinsert
> +Test unaligned fzero, rextsize=262144
> +8d87ed880ce111829bab56322a26bad0  SCRATCH_MNT/uzero
> +Test unaligned fpunch, rextsize=262144
> +8d87ed880ce111829bab56322a26bad0  SCRATCH_MNT/upunch
> +Check everything, rextsize=262144
> +Format rtextsize=327680
> +Test regular write, rextsize=327680
> +dcc4a2d49adcac61bceae7db66611880  SCRATCH_MNT/write
> +Test aligned falloc, rextsize=327680
> +63a6c5a8b8da92e30cd0ef23c56d4f06  SCRATCH_MNT/falloc
> +Test aligned fcollapse, rextsize=327680
> +8bdd728a7a4af4ac18bbcbe39dea14d5  SCRATCH_MNT/collapse
> +Test aligned finsert, rextsize=327680
> +2b178c860f7bef4c0e55399be5172c5e  SCRATCH_MNT/insert
> +Test aligned fzero, rextsize=327680
> +350defefe2530d8eb8d6a6772c81c206  SCRATCH_MNT/zero
> +Test aligned fpunch, rextsize=327680
> +350defefe2530d8eb8d6a6772c81c206  SCRATCH_MNT/punch
> +Test unaligned falloc, rextsize=327680
> +0dfbe8aa4c20b52e1b8bf3cb6cbdf193  SCRATCH_MNT/ufalloc
> +Test unaligned fcollapse, rextsize=327680
> +fallocate: Invalid argument
> +dcc4a2d49adcac61bceae7db66611880  SCRATCH_MNT/ucollapse
> +Test unaligned finsert, rextsize=327680
> +fallocate: Invalid argument
> +dcc4a2d49adcac61bceae7db66611880  SCRATCH_MNT/uinsert
> +Test unaligned fzero, rextsize=327680
> +7b728ff6048f52fa533fd902995da41b  SCRATCH_MNT/uzero
> +Test unaligned fpunch, rextsize=327680
> +7b728ff6048f52fa533fd902995da41b  SCRATCH_MNT/upunch
> +Check everything, rextsize=327680
> diff --git a/tests/xfs/group b/tests/xfs/group
> index 61d9e82b..2b3159ec 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -543,6 +543,7 @@
>  760 auto quick rw collapse punch insert zero prealloc
>  761 auto quick realtime
>  762 auto quick rw scrub realtime
> +763 auto quick rw realtime
>  908 auto quick bigtime
>  909 auto quick bigtime quota
>  910 auto quick inobtcount
> 


-- 
chandan




  reply	other threads:[~2020-10-20  5:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 21:50 [PATCH v2] xfs: fix fallocate functions when rtextsize is larger than 1 Darrick J. Wong
2020-10-17 21:51 ` [PATCH] xfstest: test fallocate ops when rt extent size is and isn't a power of 2 Darrick J. Wong
2020-10-20  5:00   ` Chandan Babu R [this message]
2020-10-19 12:53 ` [PATCH v2] xfs: fix fallocate functions when rtextsize is larger than 1 Chandan Babu R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2454211.VvKRWnKNI2@garuda \
    --to=chandanrlinux@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).