From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97428C8300F for ; Tue, 1 Dec 2020 21:05:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FDB821741 for ; Tue, 1 Dec 2020 21:05:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AuksLRLr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388839AbgLAVFl (ORCPT ); Tue, 1 Dec 2020 16:05:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60377 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388716AbgLAVFk (ORCPT ); Tue, 1 Dec 2020 16:05:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606856654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wVPezxXGFXUfwhFYqa6Djcjyd6cYjq8Fl9klsgPVelA=; b=AuksLRLrF71LV1A+e22qJDntBtixZigoXsKFN93rLsBAMKSMWX2+KLbe9quMF0rJCGlCA3 nb2RaSHPdcXkAaDJ3azEzviKLc/4pdpA6IaJFQQhcfTxHMqlTK4c4CYlWjCMkDTcQv8wmR XJtsQg2oJEqUyS3ojSMPYq10qDLPbvU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-0-5De3DzO4G1pueqNulWww-1; Tue, 01 Dec 2020 16:04:10 -0500 X-MC-Unique: 0-5De3DzO4G1pueqNulWww-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76353185E485; Tue, 1 Dec 2020 21:04:09 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-159.rdu2.redhat.com [10.10.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFF6D60854; Tue, 1 Dec 2020 21:04:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <05a0f4fd-7f62-8fbc-378d-886ccd5b3f11@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Eric Sandeen , Miklos Szeredi , Ira Weiny , linux-fsdevel , linux-man , Linux Kernel Mailing List , xfs , Ext4 Developers List , Xiaoli Feng Subject: Re: [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <300455.1606856642.1@warthog.procyon.org.uk> Date: Tue, 01 Dec 2020 21:04:02 +0000 Message-ID: <300456.1606856642@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Linus Torvalds wrote: > And if IS_DAX() is correct, then why shouldn't this just be done in > generic code? Why move it to every individual filesystem? One way of looking at it is that the check is then done for every filesystem - most of which don't support it. Not sure whether that's a big enough problem to worry about. The same is true of the automount test too, I suppose... David