Linux-XFS Archive on
 help / color / Atom feed
From: Eric Sandeen <>
To: "Darrick J. Wong" <>,
	Christoph Hellwig <>
Cc: Brian Foster <>,
Subject: Re: [PATCH] xfs: revert 1baa2800e62d ("xfs: remove the unused XFS_ALLOC_USERDATA flag")
Date: Wed, 4 Dec 2019 10:59:28 -0600
Message-ID: <> (raw)
In-Reply-To: <20190923235224.GW2229799@magnolia>

On 9/23/19 6:52 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <>
> Revert this commit, as it caused periodic regressions in xfs/173 w/
> 1k blocks[1].
> [1]
> Signed-off-by: Darrick J. Wong <>

Came across this randomly ... since there's no explanation in the changelog
as to /why/ this broke things, I think it's due to:

static inline bool
xfs_alloc_is_userdata(int datatype)
        return (datatype & ~XFS_ALLOC_NOBUSY) != 0;

which would previously have returned true if (datatype & XFS_ALLOC_USERDATA),
but without the any flag set returned false.  So failing to set
XFS_ALLOC_USERDATA indirectly changed the result of this test.

So, you're welcome, future code archaeologists.  :)


      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23 23:52 Darrick J. Wong
2019-09-24  9:39 ` Brian Foster
2019-09-24 21:30 ` Christoph Hellwig
2019-12-04 16:59 ` Eric Sandeen [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-XFS Archive on

Archives are clonable:
	git clone --mirror linux-xfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-xfs linux-xfs/ \
	public-inbox-index linux-xfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone