From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs_admin: support external log devices
Date: Mon, 2 Dec 2019 11:41:13 -0600 [thread overview]
Message-ID: <3c0b341f-cd36-10b4-b0eb-29a45867de01@sandeen.net> (raw)
In-Reply-To: <157530823862.128859.3517412709152067366.stgit@magnolia>
On 12/2/19 11:37 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Add to xfs_admin the ability to pass external log devices to xfs_db.
> This is necessary to make changes on such filesystems.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/xfs_admin.sh | 12 ++++++++++--
> man/man8/xfs_admin.8 | 3 +++
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
>
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index 305ef2b7..bd325da2 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -7,7 +7,7 @@
> status=0
> DB_OPTS=""
> REPAIR_OPTS=""
> -USAGE="Usage: xfs_admin [-efjlpuV] [-c 0|1] [-L label] [-U uuid] device"
> +USAGE="Usage: xfs_admin [-efjlpuV] [-c 0|1] [-L label] [-U uuid] device [logdev]"
>
> while getopts "efjlpuc:L:U:V" c
> do
> @@ -33,7 +33,15 @@ done
> set -- extra $@
> shift $OPTIND
> case $# in
> - 1) if [ -n "$DB_OPTS" ]
> + 1|2)
> + # Pick up the log device, if present
> + if [ -n "$2" ]; then
> + DB_OPTS=$DB_OPTS" -l '$2'"
> + test -n "$REPAIR_OPTS" && \
> + REPAIR_OPTS=$REPAIR_OPTS" -l '$2'"
> + fi
> +
> + if [ -n "$DB_OPTS" ]
> then
> eval xfs_db -x -p xfs_admin $DB_OPTS $1
> status=$?
> diff --git a/man/man8/xfs_admin.8 b/man/man8/xfs_admin.8
> index 20a114f5..d7942418 100644
> --- a/man/man8/xfs_admin.8
> +++ b/man/man8/xfs_admin.8
> @@ -15,6 +15,9 @@ xfs_admin \- change parameters of an XFS filesystem
> .I uuid
> ]
> .I device
> +[
> +.I logdev
> +]
logdev should be marked as optional, right? [logdev] ?
And documented as to when this arg should (or should not be) used?
-Eric
next prev parent reply other threads:[~2019-12-02 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 17:37 [PATCH 0/2] xfs_admin: unify online/offline fs label setting Darrick J. Wong
2019-12-02 17:37 ` [PATCH 1/2] xfs_admin: support external log devices Darrick J. Wong
2019-12-02 17:41 ` Eric Sandeen [this message]
2019-12-02 17:43 ` Darrick J. Wong
2019-12-02 17:37 ` [PATCH 2/2] xfs_admin: enable online label getting and setting Darrick J. Wong
2019-12-03 2:47 [PATCH v2 0/2] xfs_admin: unify online/offline fs label setting Darrick J. Wong
2019-12-03 2:47 ` [PATCH 1/2] xfs_admin: support external log devices Darrick J. Wong
2019-12-09 15:14 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0b341f-cd36-10b4-b0eb-29a45867de01@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).