linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs_io: add a bulkstat command
Date: Mon, 30 Sep 2019 15:02:27 -0500	[thread overview]
Message-ID: <3cdfef3d-724b-e786-131b-98454b600881@sandeen.net> (raw)
In-Reply-To: <20190927041852.GP9916@magnolia>

On 9/26/19 11:18 PM, Darrick J. Wong wrote:
>>> +
>>> +	inumbers_cmd.args =
>>> +		_("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino]");
>> <missing the -v option>
>>
>>> +	inumbers_cmd.oneline = _("Query inode groups in a filesystem");
>> I'm confused, why aren't all these ^^^ just in the structure definitions?
> All of these ... what?  I'm confused, sorry.
> 

I'm wondering why these 2 fields get set up in bulkstat_init(), vs at
cmdinfo_t structure definition time, i.e.

static cmdinfo_t        inumbers_cmd = {
        .name = "inumbers",
        .cfunc = inumbers_f,
        .argmin = 0,
        .argmax = -1,
        .flags = CMD_NOMAP_OK | CMD_FLAG_ONESHOT,
        .args =
_("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino] [-v version]");
        .oneline = _("Query inode groups in a filesystem");
        .help = inumbers_help,
};

like ~every other command does?


-Eric

  reply	other threads:[~2019-09-30 20:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 21:32 [PATCH 0/4] xfsprogs: bulkstat v5 Darrick J. Wong
2019-09-25 21:33 ` [PATCH 1/4] xfs_io: add a bulkstat command Darrick J. Wong
2019-09-26 22:40   ` Eric Sandeen
2019-09-26 22:46     ` Eric Sandeen
2019-09-27  4:18     ` Darrick J. Wong
2019-09-30 20:02       ` Eric Sandeen [this message]
2019-09-30 20:15         ` Darrick J. Wong
2019-10-07 19:13           ` Eric Sandeen
2019-09-27 20:15   ` [PATCH v2 " Darrick J. Wong
2019-09-30 20:15     ` Eric Sandeen
2019-09-25 21:33 ` [PATCH 2/4] xfs_spaceman: remove open-coded per-ag bulkstat Darrick J. Wong
2019-09-25 21:33 ` [PATCH 3/4] xfs_scrub: convert to per-ag inode bulkstat operations Darrick J. Wong
2019-09-25 21:33 ` [PATCH 4/4] xfs_scrub: batch inumbers calls during fscounters calculation Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2019-09-06  3:35 [PATCH 0/4] xfsprogs: bulkstat v5 Darrick J. Wong
2019-09-06  3:35 ` [PATCH 1/4] xfs_io: add a bulkstat command Darrick J. Wong
2019-09-12 23:51   ` Dave Chinner
2019-08-26 21:27 [PATCH 0/4] xfsprogs: bulkstat v5 Darrick J. Wong
2019-08-26 21:27 ` [PATCH 1/4] xfs_io: add a bulkstat command Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cdfef3d-724b-e786-131b-98454b600881@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).