From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574F0C64E7A for ; Wed, 2 Dec 2020 00:12:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6D522224C for ; Wed, 2 Dec 2020 00:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727378AbgLBAMH (ORCPT ); Tue, 1 Dec 2020 19:12:07 -0500 Received: from sandeen.net ([63.231.237.45]:35898 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgLBAMG (ORCPT ); Tue, 1 Dec 2020 19:12:06 -0500 Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id 2799D146284; Tue, 1 Dec 2020 18:11:09 -0600 (CST) To: Linus Torvalds , David Howells Cc: Eric Sandeen , Miklos Szeredi , Ira Weiny , linux-fsdevel , linux-man , Linux Kernel Mailing List , xfs , Ext4 Developers List , Xiaoli Feng References: <05a0f4fd-7f62-8fbc-378d-886ccd5b3f11@redhat.com> <300456.1606856642@warthog.procyon.org.uk> From: Eric Sandeen Subject: Re: [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems Message-ID: <421cb25d-ca52-0a08-e535-5f650dda8d93@sandeen.net> Date: Tue, 1 Dec 2020 18:11:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 12/1/20 4:09 PM, Linus Torvalds wrote: > So basically, the thing that argues against this patch is that it > seems to just duplicate things inside filesystems, when the VFS layter > already has the information. > > Now, if the VFS information was possibly stale or wrong, that woudl be > one thing. But then we'd have other and bigger problems elsewhere as > far as I can tell. > > IOW - make generic what can be made generic, and try to avoid having > filesystems do their own thing. > > [ Replace "filesystems" by "architectures" or whatever else, this is > obviously not a filesystem-specific rule in general. ] > > And don't get me wrong - I don't _hate_ the patch, and I don't care > _that_ deeply, but it just doesn't seem to make any sense to me. My > initial query was really about "what am I missing - can you please > flesh out the commit message because I don't understand what's wrong". Backing way up, my motivation was: Only the filesystem can appropriately set the statx->attributes_mask, so it has to be done there. Since that has to be done in the filesystem, set the actual attribute flag adjacent to it, as is done for ~every other flag. *shrug* In any case I resent the flag value clash fix on a separate thread as V2, hopefully that one is straightforward enough to go in. Thanks, -Eric