linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: <guaneryu@gmail.com>, <jbacik@fusionio.com>,
	<fstests@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
	<zhengbin13@huawei.com>, <yi.zhang@huawei.com>
Subject: Re: [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability
Date: Thu, 16 Jan 2020 20:22:00 +0800	[thread overview]
Message-ID: <51e99fd5-617f-6558-7a04-c4a198139cdd@huawei.com> (raw)
In-Reply-To: <20200109164615.GA8247@magnolia>



ON 2020/1/10 0:46, Darrick J. Wong wrote:
> It sounds like a reasonable idea, though I was suggesting doing the
> snapshot-and-check in the xfs_db source, not fstests.

The problem is that blocktrash do changed some bits of the attr block,
however, corrupt will still fail if the change is only inside the 'zero'
range.

So, I think it's hard to fix the problem by doing the snapshot-and-check
in the xfs_db source.

Thanks!
Yu Kuai


  reply	other threads:[~2020-01-16 12:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  9:27 [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability yu kuai
2020-01-08 16:22 ` Darrick J. Wong
2020-01-09  3:56   ` yukuai (C)
2020-01-09  4:00   ` yukuai (C)
2020-01-09 16:46     ` Darrick J. Wong
2020-01-16 12:22       ` yukuai (C) [this message]
2020-01-16 16:03         ` Darrick J. Wong
2020-01-17  2:20           ` yukuai (C)
2020-01-17  3:10             ` yukuai (C)
2020-01-17  6:15               ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51e99fd5-617f-6558-7a04-c4a198139cdd@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).