From: kaixuxia <xiakaixu1987@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
newtongao@tencent.com, jasperwang@tencent.com
Subject: [PATCH 2/2] xfs: test the deadlock between the AGI and AGF with RENAME_WHITEOUT
Date: Wed, 11 Sep 2019 21:17:08 +0800 [thread overview]
Message-ID: <58163375-dcd9-b954-c8d2-89fef20b8246@gmail.com> (raw)
There is ABBA deadlock bug between the AGI and AGF when performing
rename() with RENAME_WHITEOUT flag, and add this testcase to make
sure the rename() call works well.
Signed-off-by: kaixuxia <kaixuxia@tencent.com>
---
tests/xfs/512 | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/xfs/512.out | 2 ++
tests/xfs/group | 1 +
3 files changed, 102 insertions(+)
create mode 100755 tests/xfs/512
create mode 100644 tests/xfs/512.out
diff --git a/tests/xfs/512 b/tests/xfs/512
new file mode 100755
index 0000000..754f102
--- /dev/null
+++ b/tests/xfs/512
@@ -0,0 +1,99 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2019 Tencent. All Rights Reserved.
+#
+# FS QA Test 512
+#
+# Test the ABBA deadlock case between the AGI and AGF When performing
+# rename operation with RENAME_WHITEOUT flag.
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/renameat2
+
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+_require_scratch_nocheck
+_requires_renameat2 whiteout
+
+prepare_file()
+{
+ # create many small files for the rename with RENAME_WHITEOUT
+ i=0
+ while [ $i -le $files ]; do
+ file=$SCRATCH_MNT/f$i
+ echo > $file >/dev/null 2>&1
+ let i=$i+1
+ done
+}
+
+rename_whiteout()
+{
+ # create the rename targetdir
+ renamedir=$SCRATCH_MNT/renamedir
+ mkdir $renamedir
+
+ # a long filename could increase the possibility that target_dp
+ # allocate new blocks(acquire the AGF lock) to store the filename
+ longnamepre=FFFsafdsagafsadfagasdjfalskdgakdlsglkasdg
+
+ # now try to do rename with RENAME_WHITEOUT flag
+ i=0
+ while [ $i -le $files ]; do
+ src/renameat2 -w $SCRATCH_MNT/f$i $renamedir/$longnamepre$i >/dev/null 2>&1
+ let i=$i+1
+ done
+}
+
+create_file()
+{
+ # create the targetdir
+ createdir=$SCRATCH_MNT/createdir
+ mkdir $createdir
+
+ # try to create file at the same time to hit the deadlock
+ i=0
+ while [ $i -le $files ]; do
+ file=$createdir/f$i
+ echo > $file >/dev/null 2>&1
+ let i=$i+1
+ done
+}
+
+_scratch_mkfs_xfs -bsize=1024 -dagcount=1 >> $seqres.full 2>&1 ||
+ _fail "mkfs failed"
+_scratch_mount
+
+files=250000
+
+prepare_file
+rename_whiteout &
+create_file &
+
+wait
+echo Silence is golden
+
+# Failure comes in the form of a deadlock.
+
+# success, all done
+status=0
+exit
diff --git a/tests/xfs/512.out b/tests/xfs/512.out
new file mode 100644
index 0000000..0aabdef
--- /dev/null
+++ b/tests/xfs/512.out
@@ -0,0 +1,2 @@
+QA output created by 512
+Silence is golden
diff --git a/tests/xfs/group b/tests/xfs/group
index a7ad300..ed250d6 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -509,3 +509,4 @@
509 auto ioctl
510 auto ioctl quick
511 auto quick quota
+512 auto rename
--
1.8.3.1
--
kaixuxia
next reply other threads:[~2019-09-11 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:17 kaixuxia [this message]
2019-09-13 17:36 ` [PATCH 2/2] xfs: test the deadlock between the AGI and AGF with RENAME_WHITEOUT Brian Foster
2019-09-15 3:34 ` Eryu Guan
2019-09-15 11:47 ` Brian Foster
2019-09-15 13:27 ` Eryu Guan
2019-09-16 5:12 ` kaixuxia
2019-09-16 6:33 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58163375-dcd9-b954-c8d2-89fef20b8246@gmail.com \
--to=xiakaixu1987@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jasperwang@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=newtongao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).