From: Ian Kent <raven@themaw.net>
To: Christoph Hellwig <hch@lst.de>, Jan Stancek <jstancek@redhat.com>
Cc: kernel test robot <rong.a.chen@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org, lkp@lists.01.org, ltp@lists.linux.it,
DavidHowells <dhowells@redhat.com>,
AlViro <viro@ZenIV.linux.org.uk>
Subject: Re: [LTP] [xfs] 73e5fff98b: kmsg.dev/zero:Can't_open_blockdev
Date: Wed, 13 Nov 2019 09:13:22 +0800 [thread overview]
Message-ID: <5f758be455bb8f761d028ea078b3e2a618dfd4b1.camel@themaw.net> (raw)
In-Reply-To: <20191112120818.GA8858@lst.de>
Adding Al and David to the CC, hopefully that will draw their
attention to this a bit sooner.
On Tue, 2019-11-12 at 13:08 +0100, Christoph Hellwig wrote:
> On Tue, Nov 12, 2019 at 07:02:23AM -0500, Jan Stancek wrote:
> > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/fs/fs_fill/fs_fill.c
> >
> > Setup of that test is trying different file system types, and it
> > looks
> > at errno code of "mount -t $fs /dev/zero /mnt/$fs".
> >
> > Test still PASSes. This report appears to be only about extra
> > message in dmesg,
> > which wasn't there before:
> >
> > # mount -t xfs /dev/zero /mnt/xfs
Assuming that is what is being done ...
> > # dmesg -c
> > [ 897.177168] /dev/zero: Can't open blockdev
>
> That message comes from fs/super.c:get_tree_bdev(), a common library
> used by all block device based file systems using the new mount API.
I'll have a look at get_tree_bdev() but when I compared mount_bdev()
to get_tree_bdev() before using it they looked like they did pretty
much the same thing.
I don't know how /dev/zero is meant to be handled, I'll need to try
and work that out if Al or David don't see this soon enough.
>
> It doesn't seem all that useful to me, but it is something we'll
> need to discuss with David and Al, not the XFS maintainers.
Ian
next prev parent reply other threads:[~2019-11-13 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:00 [xfs] 73e5fff98b: kmsg.dev/zero:Can't_open_blockdev kernel test robot
2019-11-12 8:39 ` Ian Kent
2019-11-12 12:02 ` [LTP] " Jan Stancek
2019-11-12 12:08 ` Christoph Hellwig
2019-11-13 1:13 ` Ian Kent [this message]
2019-11-13 6:04 ` Ian Kent
2019-11-13 6:16 ` Jan Stancek
2019-11-14 0:44 ` Rong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f758be455bb8f761d028ea078b3e2a618dfd4b1.camel@themaw.net \
--to=raven@themaw.net \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=ltp@lists.linux.it \
--cc=rong.a.chen@intel.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).