From: Chandan Babu R <chandanrlinux@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH V6 08/11] xfs: Check for extent overflow when remapping an extent
Date: Sat, 17 Oct 2020 08:25:01 +0530 [thread overview]
Message-ID: <6492308.izWhvZ5asW@garuda> (raw)
In-Reply-To: <20201016152900.GD9832@magnolia>
On Friday 16 October 2020 8:59:00 PM IST Darrick J. Wong wrote:
> On Fri, Oct 16, 2020 at 04:58:53PM +0530, Chandan Babu R wrote:
> > On Friday 16 October 2020 12:34:48 PM IST Christoph Hellwig wrote:
> > > On Thu, Oct 15, 2020 at 03:31:26PM +0530, Chandan Babu R wrote:
> > > > How about following the traits of XFS_IEXT_WRITE_UNWRITTEN_CNT (writing
> > > > to unwritten extent) and XFS_IEXT_REFLINK_END_COW_CNT (moving an extent
> > > > from cow fork to data fork) and setting XFS_IEXT_REFLINK_REMAP_CNT to a
> > > > worst case value of 2? A write spanning the entirety of an unwritten extent
> > > > does not change the extent count. Similarly, If there are no extents in the
> > > > data fork spanning the file range mapped by an extent in the cow
> > > > fork, moving the extent from cow fork to data fork increases the extent count
> > > > by just 1 and not by the worst case count of 2.
> > >
> > > No, I think the dynamic value is perfectly fine, as we have all the
> > > information trivially available. I just don't think having a separate
> > > macro and the comment explaining it away from the actual functionality
> > > is helpful.
> > >
> >
> > Darrick, I think using the macros approach is more suitable. But I can go
> > ahead and implement the approach decided by the community. Please let me know
> > your opinion.
>
> The macro only gets used in one place anyway, so I don't see as strong a
> need for it as the other places. I think this one could be open-coded
> next to the places where we decide the values of smap_real and
> dmap_written. (i.e. what Christoph is suggesting)
>
Ok. I will make the relevant changes.
--
chandan
next prev parent reply other threads:[~2020-10-17 6:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 9:29 [PATCH V6 00/11] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-10-12 9:29 ` [PATCH V6 01/11] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-10-15 8:34 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 02/11] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-10-15 8:34 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 03/11] xfs: Check for extent overflow when punching a hole Chandan Babu R
2020-10-15 8:35 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 04/11] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-10-15 8:36 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 05/11] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-10-15 8:36 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 06/11] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-10-15 8:36 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 07/11] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-10-15 8:37 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 08/11] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-10-15 8:39 ` Christoph Hellwig
2020-10-15 10:01 ` Chandan Babu R
2020-10-15 18:45 ` Darrick J. Wong
2020-10-16 4:27 ` Chandan Babu R
2020-10-16 7:04 ` Christoph Hellwig
2020-10-16 11:28 ` Chandan Babu R
2020-10-16 15:29 ` Darrick J. Wong
2020-10-17 2:55 ` Chandan Babu R [this message]
2020-10-12 9:29 ` [PATCH V6 09/11] xfs: Check for extent overflow when swapping extents Chandan Babu R
2020-10-12 9:29 ` [PATCH V6 10/11] xfs: Introduce error injection to reduce maximum inode fork extent count Chandan Babu R
2020-10-15 8:40 ` Christoph Hellwig
2020-10-12 9:29 ` [PATCH V6 11/11] xfs: Introduce error injection to allocate only minlen size extents for files Chandan Babu R
2020-10-15 8:41 ` Christoph Hellwig
2020-10-15 10:02 ` Chandan Babu R
2020-10-15 18:41 ` Darrick J. Wong
2020-10-16 11:31 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6492308.izWhvZ5asW@garuda \
--to=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).