From: Chandan Rajendra <chandan@linux.ibm.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Chandan Rajendra <chandanrlinux@gmail.com>,
linux-xfs@vger.kernel.org, david@fromorbit.com,
darrick.wong@oracle.com
Subject: Re: [PATCH V3 1/2] xfs: Pass xattr name and value length explicitly to xfs_attr_leaf_newentsize
Date: Mon, 17 Feb 2020 13:27:10 +0530 [thread overview]
Message-ID: <6991250.kRB6YAzXHl@localhost.localdomain> (raw)
In-Reply-To: <20200212151115.GA17921@bfoster>
On Wednesday, February 12, 2020 8:41 PM Brian Foster wrote:
> On Wed, Jan 29, 2020 at 10:29:38AM +0530, Chandan Rajendra wrote:
> > This commit changes xfs_attr_leaf_newentsize() to explicitly accept name and
> > value length instead of a pointer to struct xfs_da_args. The next commit will
> > need to invoke xfs_attr_leaf_newentsize() from functions that do not have
> > a struct xfs_da_args to pass in.
> >
> > Signed-off-by: Chandan Rajendra <chandanrlinux@gmail.com>
> > ---
> > fs/xfs/libxfs/xfs_attr.c | 3 ++-
> > fs/xfs/libxfs/xfs_attr_leaf.c | 41 ++++++++++++++++++++++++-----------
> > fs/xfs/libxfs/xfs_attr_leaf.h | 3 ++-
> > 3 files changed, 32 insertions(+), 15 deletions(-)
> >
> ...
> > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> > index 08d4b10ae2d53..7cd57e5844d80 100644
> > --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> > +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> ...
> > @@ -2687,20 +2700,22 @@ xfs_attr_leaf_entsize(xfs_attr_leafblock_t *leaf, int index)
> > */
> > int
> > xfs_attr_leaf_newentsize(
> > - struct xfs_da_args *args,
> > + struct xfs_mount *mp,
>
> Any reason not to just pass the geo here rather than the mount?
> Otherwise looks fine to me.
Sorry, I noticed this message now.
You are right. I will change the first argument to be attr geometry pointer.
--
chandan
prev parent reply other threads:[~2020-02-17 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 4:59 [PATCH V3 1/2] xfs: Pass xattr name and value length explicitly to xfs_attr_leaf_newentsize Chandan Rajendra
2020-01-29 4:59 ` [PATCH V3 2/2] xfs: Fix log reservation calculation for xattr insert operation Chandan Rajendra
2020-02-12 15:13 ` Brian Foster
2020-02-13 14:47 ` Chandan Rajendra
2020-02-12 17:27 ` Darrick J. Wong
2020-02-12 15:11 ` [PATCH V3 1/2] xfs: Pass xattr name and value length explicitly to xfs_attr_leaf_newentsize Brian Foster
2020-02-17 7:57 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6991250.kRB6YAzXHl@localhost.localdomain \
--to=chandan@linux.ibm.com \
--cc=bfoster@redhat.com \
--cc=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).