From: Eric Sandeen <sandeen@redhat.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 0/2] xfs: fix up some reflink+dax interactions
Date: Tue, 1 Dec 2020 13:23:00 -0600 [thread overview]
Message-ID: <7680868b-d804-faf2-9fbd-f03ca8a69fdd@redhat.com> (raw)
In-Reply-To: <1d87a83e-ba03-b735-f19a-955a09bcdcf7@redhat.com>
On 12/1/20 1:10 PM, Eric Sandeen wrote:
> dax behavior has changed semi-recently, most notably that per-inode dax
> flags are back, which opens the possibility of dax-capable files existing on
> reflink-capable filesystems.
>
> While we still have a reflink-vs-dax-on-the-same-file incompatibilty, and for
> the most part this is handled correctly, there are a couple of known issues:
>
> 1) xfs_dinode_verify will trap an inode with reflink+dax flags as corrupted;
> this needs to be removed, because we actually can get into this state today,
> and eventually that state will be supported in future kernels.
>
> 2) (more RFC) until we actually support reflink+dax files, perhaps we should
> prevent the flags from co-existing in a kernel that cannot support both
> states. patch 2 stops us from reflinking files with the dax flag set,
> whether or not the file is actually "in the CPU direct access state"
>
> -Eric
Also yes I owe xfstests for these but wanted to see if the patches fly, first.
-Eric
prev parent reply other threads:[~2020-12-01 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 19:10 [PATCH 0/2] xfs: fix up some reflink+dax interactions Eric Sandeen
2020-12-01 19:16 ` [PATCH 1/2] xfs: don't catch dax+reflink inodes as corruption in verifier Eric Sandeen
2020-12-02 10:16 ` Christoph Hellwig
2020-12-03 21:44 ` Darrick J. Wong
2020-12-03 22:19 ` Eric Sandeen
2020-12-03 23:03 ` Darrick J. Wong
2020-12-01 19:20 ` [RFC PATCH 2/2] xfs: do not allow reflinking inodes with the dax flag set Eric Sandeen
2020-12-02 10:22 ` Christoph Hellwig
2020-12-02 14:44 ` Eric Sandeen
2020-12-02 17:15 ` Christoph Hellwig
2020-12-02 17:15 ` Christoph Hellwig
2020-12-01 19:23 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7680868b-d804-faf2-9fbd-f03ca8a69fdd@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).