From: "Yang, Xiao/杨 晓" <yangx.jy@fujitsu.com>
To: "Brian Foster" <bfoster@redhat.com>,
"Ruan, Shiyang/阮 世阳" <ruansy.fnst@fujitsu.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition
Date: Wed, 14 Sep 2022 17:38:02 +0800 [thread overview]
Message-ID: <76ea04b4-bad7-8cb3-d2c6-4ad49def4e05@fujitsu.com> (raw)
In-Reply-To: <7fdc9e88-f255-6edb-7964-a5a82e9b1292@fujitsu.com>
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
> On 2022/9/9 21:01, Brian Foster wrote:
>> Yes.. I don't recall all the internals of the tools and test, but IIRC
>> it relied on discard to perform zeroing between checkpoints or some such
>> and avoid spurious failures. The purpose of running on dm-thin was
>> merely to provide reliable discard zeroing behavior on the target device
>> and thus to allow the test to run reliably.
> Hi Brian,
>
> As far as I know, generic/470 was original designed to verify
> mmap(MAP_SYNC) on the dm-log-writes device enabling DAX. Due to the
> reason, we need to ensure that all underlying devices under
> dm-log-writes device support DAX. However dm-thin device never supports
> DAX so
> running generic/470 with dm-thin device always returns "not run".
>
> Please see the difference between old and new logic:
>
> old logic new logic
> ---------------------------------------------------------------
> log-writes device(DAX) log-writes device(DAX)
> | |
> PMEM0(DAX) + PMEM1(DAX) Thin device(non-DAX) + PMEM1(DAX)
> |
> PMEM0(DAX)
> ---------------------------------------------------------------
>
> We think dm-thin device is not a good solution for generic/470, is there
> any other solution to support both discard zero and DAX?
Hi Brian,
I have sent a patch[1] to revert your fix because I think it's not good
for generic/470 to use thin volume as my revert patch[1] describes:
[1]
https://lore.kernel.org/fstests/20220914090625.32207-1-yangx.jy@fujitsu.com/T/#u
With the revert, generic/470 can always run successfully on my
environment so I wonder how to reproduce the out-of-order replay issue
on XFS v5 filesystem?
PS: I want to reproduce the issue and try to find a better solution to
fix it.
Best Regards,
Xiao Yang
>
> BTW, only log-writes, stripe and linear support DAX for now.
next prev parent reply other threads:[~2022-09-14 9:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 14:34 [PATCH] xfs: fail dax mount if reflink is enabled on a partition Shiyang Ruan
2022-06-10 5:46 ` Christoph Hellwig
2022-07-01 0:31 ` Darrick J. Wong
2022-07-01 5:14 ` Shiyang Ruan
2022-07-21 12:43 ` ruansy.fnst
2022-07-21 14:06 ` ruansy.fnst
2022-07-21 16:16 ` Darrick J. Wong
2022-07-29 3:55 ` ruansy.fnst
2022-07-29 4:54 ` Darrick J. Wong
2022-08-03 6:47 ` ruansy.fnst
2022-08-04 0:51 ` Darrick J. Wong
2022-08-04 1:36 ` Shiyang Ruan
2022-09-08 13:46 ` Shiyang Ruan
2022-09-09 13:01 ` Brian Foster
2022-09-14 6:44 ` Yang, Xiao/杨 晓
2022-09-14 9:38 ` Yang, Xiao/杨 晓 [this message]
2022-09-14 12:34 ` Brian Foster
2022-09-14 16:28 ` Darrick J. Wong
2022-09-15 10:14 ` Yang, Xiao/杨 晓
2022-09-16 2:04 ` Yang, Xiao/杨 晓
2022-09-20 2:38 ` Yang, Xiao/杨 晓
2022-09-30 0:56 ` Gotou, Yasunori/五島 康文
2022-10-04 0:12 ` Darrick J. Wong
2022-10-04 4:12 ` Gotou, Yasunori/五島 康文
2022-10-04 18:26 ` Darrick J. Wong
2022-10-20 14:17 ` Yang, Xiao/杨 晓
2022-10-22 2:11 ` Darrick J. Wong
[not found] ` <09f522cd-e846-12ee-d662-14f34a2977c4@fujitsu.com>
2022-10-23 7:04 ` yangx.jy
2022-10-23 22:00 ` Dave Chinner
2022-10-24 3:17 ` ruansy.fnst
2022-10-24 4:05 ` Darrick J. Wong
2022-10-24 5:31 ` Dave Chinner
2022-10-25 14:26 ` ruansy.fnst
2022-10-25 17:56 ` Darrick J. Wong
2022-10-27 21:08 ` Darrick J. Wong
2022-10-28 1:37 ` Dan Williams
2022-10-30 9:31 ` Shiyang Ruan
2022-11-02 0:45 ` Darrick J. Wong
2022-11-02 5:17 ` ruansy.fnst
2022-11-03 2:32 ` Dave Chinner
2022-10-24 17:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76ea04b4-bad7-8cb3-d2c6-4ad49def4e05@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).