From: Markus Elfring <Markus.Elfring@web.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jth@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [v10 1/2] fs: New zonefs file system
Date: Wed, 5 Feb 2020 11:44:54 +0100 [thread overview]
Message-ID: <827e50c9-c847-0398-2820-46e210f0fc4d@web.de> (raw)
In-Reply-To: <BYAPR04MB5816A4CD15C760D0E5768285E7020@BYAPR04MB5816.namprd04.prod.outlook.com>
>> I propose to define this array also as a completely immutable data structure.
>
> I understood that and pointed out that the added "const" does not change a thing.
Should the stored pointers be constants (besides the corresponding string literals)?
> I think that as is, it already is immutable.
Would you like to distinguish the scope for items in this variable a bit more?
Are any other software components similarly affected?
Regards,
Markus
prev parent reply other threads:[~2020-02-05 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:46 [PATCH v10 1/2] fs: New zonefs file system Markus Elfring
2020-02-05 1:35 ` Damien Le Moal
2020-02-05 7:16 ` [v10 " Markus Elfring
2020-02-05 7:46 ` Damien Le Moal
2020-02-05 10:44 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=827e50c9-c847-0398-2820-46e210f0fc4d@web.de \
--to=markus.elfring@web.de \
--cc=Damien.LeMoal@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).