From: Allison Collins <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] libxfs: re-sort libxfs_api_defs.h defines
Date: Tue, 4 Feb 2020 22:28:43 -0700 [thread overview]
Message-ID: <82b5ccf7-c147-8df6-5c03-ef5dc6db341a@oracle.com> (raw)
In-Reply-To: <158086357391.2079557.7271114884346251108.stgit@magnolia>
On 2/4/20 5:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Re-fix the sorting in this file.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks ok to me
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
> ---
> libxfs/libxfs_api_defs.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>
> diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h
> index c7fa1607..6e09685b 100644
> --- a/libxfs/libxfs_api_defs.h
> +++ b/libxfs/libxfs_api_defs.h
> @@ -93,6 +93,7 @@
> #define xfs_dqblk_repair libxfs_dqblk_repair
> #define xfs_dquot_verify libxfs_dquot_verify
>
> +#define xfs_finobt_calc_reserves libxfs_finobt_calc_reserves
> #define xfs_free_extent libxfs_free_extent
> #define xfs_fs_geometry libxfs_fs_geometry
> #define xfs_highbit32 libxfs_highbit32
> @@ -118,13 +119,16 @@
> #define xfs_perag_put libxfs_perag_put
> #define xfs_prealloc_blocks libxfs_prealloc_blocks
>
> +#define xfs_read_agf libxfs_read_agf
> #define xfs_refc_block libxfs_refc_block
> +#define xfs_refcountbt_calc_reserves libxfs_refcountbt_calc_reserves
> #define xfs_refcountbt_init_cursor libxfs_refcountbt_init_cursor
> #define xfs_refcountbt_maxrecs libxfs_refcountbt_maxrecs
> #define xfs_refcount_get_rec libxfs_refcount_get_rec
> #define xfs_refcount_lookup_le libxfs_refcount_lookup_le
>
> #define xfs_rmap_alloc libxfs_rmap_alloc
> +#define xfs_rmapbt_calc_reserves libxfs_rmapbt_calc_reserves
> #define xfs_rmapbt_init_cursor libxfs_rmapbt_init_cursor
> #define xfs_rmapbt_maxrecs libxfs_rmapbt_maxrecs
> #define xfs_rmap_compare libxfs_rmap_compare
> @@ -176,9 +180,6 @@
> #define xfs_verify_rtbno libxfs_verify_rtbno
> #define xfs_zero_extent libxfs_zero_extent
>
> -#define xfs_refcountbt_calc_reserves libxfs_refcountbt_calc_reserves
> -#define xfs_finobt_calc_reserves libxfs_finobt_calc_reserves
> -#define xfs_rmapbt_calc_reserves libxfs_rmapbt_calc_reserves
> -#define xfs_read_agf libxfs_read_agf
> +/* Please keep this list alphabetized. */
>
> #endif /* __LIBXFS_API_DEFS_H__ */
>
next prev parent reply other threads:[~2020-02-05 5:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 0:46 [PATCH 0/4] xfsprogs: random fixes Darrick J. Wong
2020-02-05 0:46 ` [PATCH 1/4] libxfs: re-sort libxfs_api_defs.h defines Darrick J. Wong
2020-02-05 2:11 ` Chaitanya Kulkarni
2020-02-05 5:28 ` Allison Collins [this message]
2020-02-17 13:45 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 2/4] libfrog: remove libxfs.h dependencies in fsgeom.c and linux.c Darrick J. Wong
2020-02-05 5:28 ` Allison Collins
2020-02-17 13:46 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 3/4] xfs_repair: refactor attr root block pointer check Darrick J. Wong
2020-02-05 5:28 ` Allison Collins
2020-02-13 23:14 ` Eric Sandeen
2020-02-14 4:24 ` Darrick J. Wong
2020-02-17 13:47 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 4/4] xfs_repair: don't corrupt a attr fork da3 node when clearing forw/back Darrick J. Wong
2020-02-05 5:29 ` Allison Collins
2020-02-05 5:59 ` Darrick J. Wong
2020-02-17 13:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b5ccf7-c147-8df6-5c03-ef5dc6db341a@oracle.com \
--to=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).