From: Chandan Babu R <chandanrlinux@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org,
chandanrlinux@gmail.com, Chaitanya.Kulkarni@wdc.com
Subject: Re: [PATCH 6/6] xfs_scrub: fix weirdness in directory name check code
Date: Wed, 10 Feb 2021 15:34:37 +0530 [thread overview]
Message-ID: <875z30p7be.fsf@garuda> (raw)
In-Reply-To: <161284390991.3058224.12921304382202456726.stgit@magnolia>
On 09 Feb 2021 at 09:41, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Remove the redundant second check of fd and ISDIR in check_inode_names,
> and rework the comment to describe why we can't run phase 5 if we found
> other corruptions in the filesystem.
>
Looks good to me.
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> scrub/phase5.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>
> diff --git a/scrub/phase5.c b/scrub/phase5.c
> index ee1e5d6c..1ef234bf 100644
> --- a/scrub/phase5.c
> +++ b/scrub/phase5.c
> @@ -278,7 +278,12 @@ check_inode_names(
> goto out;
> }
>
> - /* Open the dir, let the kernel try to reconnect it to the root. */
> + /*
> + * Warn about naming problems in the directory entries. Opening the
> + * dir by handle means the kernel will try to reconnect it to the root.
> + * If the reconnection fails due to corruption in the parents we get
> + * ESTALE, which is why we skip phase 5 if we found corruption.
> + */
> if (S_ISDIR(bstat->bs_mode)) {
> fd = scrub_open_handle(handle);
> if (fd < 0) {
> @@ -288,10 +293,7 @@ check_inode_names(
> str_errno(ctx, descr_render(&dsc));
> goto out;
> }
> - }
>
> - /* Warn about naming problems in the directory entries. */
> - if (fd >= 0 && S_ISDIR(bstat->bs_mode)) {
> error = check_dirent_names(ctx, &dsc, &fd, bstat);
> if (error)
> goto out;
--
chandan
prev parent reply other threads:[~2021-02-10 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 4:11 [PATCHSET v4 0/6] various: random fixes Darrick J. Wong
2021-02-09 4:11 ` [PATCH 1/6] misc: fix valgrind complaints Darrick J. Wong
2021-02-09 9:19 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 2/6] xfs_scrub: detect infinite loops when scanning inodes Darrick J. Wong
2021-02-09 9:26 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 3/6] xfs_scrub: load and unload libicu properly Darrick J. Wong
2021-02-09 9:28 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 4/6] xfs_scrub: handle concurrent directory updates during name scan Darrick J. Wong
2021-02-09 9:30 ` Christoph Hellwig
2021-02-09 16:53 ` Darrick J. Wong
2021-02-09 4:11 ` [PATCH 5/6] xfs_repair: check dquot id and type Darrick J. Wong
2021-02-09 9:31 ` Christoph Hellwig
2021-02-09 16:55 ` Darrick J. Wong
2021-02-10 9:48 ` Chandan Babu R
2021-02-11 17:06 ` [PATCH v4.1 " Darrick J. Wong
2021-02-12 12:08 ` Chandan Babu R
2021-02-09 4:11 ` [PATCH 6/6] xfs_scrub: fix weirdness in directory name check code Darrick J. Wong
2021-02-09 9:31 ` Christoph Hellwig
2021-02-10 10:04 ` Chandan Babu R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z30p7be.fsf@garuda \
--to=chandanrlinux@gmail.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).