linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <djwong@kernel.org>,
	Eric Sandeen <esandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>, Bill O'Donnell <bodonnel@redhat.com>
Subject: Re: [PATCH] mkfs.xfs.8: clarify DAX-vs-reflink restrictions in the mkfs.xfs man page
Date: Fri, 27 Aug 2021 11:23:22 -0500	[thread overview]
Message-ID: <8c478cd9-31cf-d659-0088-949519cf11bc@sandeen.net> (raw)
In-Reply-To: <20210827154905.GP12640@magnolia>

On 8/27/21 10:49 AM, Darrick J. Wong wrote:
> On Fri, Aug 27, 2021 at 10:39:18AM -0500, Eric Sandeen wrote:
>> Now that we have the tristate dax mount options, it is possible
>> to enable DAX mode for non-reflinked files on a reflink-capable
>> filesystem.  Clarify this in the mkfs.xfs manpage.
>>
>> Reported-by: Bill O'Donnell <bodonnel@redhat.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
>> index a7f70285..84ac50e8 100644
>> --- a/man/man8/mkfs.xfs.8
>> +++ b/man/man8/mkfs.xfs.8
>> @@ -316,12 +316,20 @@ option set. When the option
>>   is used, the reference count btree feature is not supported and reflink is
>>   disabled.
>>   .IP
>> -Note: the filesystem DAX mount option (
>> +Note: the filesystem-wide DAX mount options (
>>   .B \-o dax
>> -) is incompatible with
>> -reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
>> +and
>> +.B \-o dax=always
>> +) are incompatible with
>> +reflink-enabled XFS filesystems.  To use filesystem-wide DAX with XFS, specify the
>>   .B \-m reflink=0
>>   option to mkfs.xfs to disable the reflink feature.
>> +Alternatey, use the
> 
> "Alternately..."

"Alternatively,"

> 
>> +.B \-o dax=inode
>> +mount option to selectively enable DAX mode on non-reflinked files.
> 
> /me wonders if this is dangerously close to wading into the muck that is
> "Use dax=inode or even no dax option at all, then make sure nobody
> shares your file's data blocks to set the DAX fsxattr flag on the file,
> and /then/ you can have DAX."

Perhaps I should drop most of it, and just wave hands vaguely at xfs.5?

-Eric

      reply	other threads:[~2021-08-27 16:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 15:39 [PATCH] mkfs.xfs.8: clarify DAX-vs-reflink restrictions in the mkfs.xfs man page Eric Sandeen
2021-08-27 15:46 ` Bill O'Donnell
2021-08-27 15:47   ` Eric Sandeen
2021-08-27 15:49 ` Darrick J. Wong
2021-08-27 16:23   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c478cd9-31cf-d659-0088-949519cf11bc@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bodonnel@redhat.com \
    --cc=djwong@kernel.org \
    --cc=esandeen@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).