From: Eric Sandeen <sandeen@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix sparse checker warnings on kmem tracepoints
Date: Wed, 18 Dec 2019 17:27:28 -0600 [thread overview]
Message-ID: <91759bbe-2256-92da-249b-751aac997d82@redhat.com> (raw)
In-Reply-To: <20191218231152.GL7489@magnolia>
On 12/18/19 5:11 PM, Darrick J. Wong wrote:
> On Wed, Dec 18, 2019 at 04:18:16PM -0600, Eric Sandeen wrote:
>> Sparse checker doesn't like kmem.c tracepoints:
>>
>> kmem.c:18:32: warning: incorrect type in argument 2 (different base types)
>> kmem.c:18:32: expected int [signed] flags
>> kmem.c:18:32: got restricted xfs_km_flags_t [usertype] flags
>>
>> So take an xfs_km_flags_t, and cast it to an int when we print it.
>>
>> Fixes: 0ad95687c3ad ("xfs: add kmem allocation trace points")
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks ok insofar as cem will eventually kill these off, right?
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Oh, I guess so - if you want to just wait for that and drop this
patch, it's fine.
-Eric
prev parent reply other threads:[~2019-12-18 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 22:18 [PATCH] xfs: fix sparse checker warnings on kmem tracepoints Eric Sandeen
2019-12-18 23:11 ` Darrick J. Wong
2019-12-18 23:27 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91759bbe-2256-92da-249b-751aac997d82@redhat.com \
--to=sandeen@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).