From: Eric Sandeen <sandeen@sandeen.net>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>, linux-xfs@vger.kernel.org
Cc: darrick.wong@oracle.com, david@fromorbit.com, hch@infradead.org
Subject: Re: [PATCH v2] xfs_io: Make -D and -R options incompatible explicitly
Date: Wed, 29 Jul 2020 17:45:17 -0700 [thread overview]
Message-ID: <93c05acc-20b6-f559-504b-da62a9963d2b@sandeen.net> (raw)
In-Reply-To: <20200724063253.22247-1-yangx.jy@cn.fujitsu.com>
On 7/23/20 11:32 PM, Xiao Yang wrote:
> -D and -R options are mutually exclusive actually but many commands
> can accept them at the same time and process them differently(e.g.
> chattr alway chooses -D option or cowextsize accepts the last one
> specified), so make these commands have the consistent behavior that
> don't accept them concurrently.
>
> 1) Make them incompatible by setting argmax to 1 if commands can accept
> single option(i.e. lsattr, lsproj).
I see that lsattr already has argmax=1, so I guess that was ok.
Still good to remove the extra vars from the cases.
> 2) Make them incompatible by adding check if commands can accept multiple
> options(i.e. chattr, chproj, extsize, cowextsize).
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Thank you for cleaning all of these up.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
prev parent reply other threads:[~2020-07-30 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 6:32 [PATCH v2] xfs_io: Make -D and -R options incompatible explicitly Xiao Yang
2020-07-30 0:45 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c05acc-20b6-f559-504b-da62a9963d2b@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).