From: Felix Kuehling <felix.kuehling@amd.com>
To: Alex Sierra <alex.sierra@amd.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
hch@lst.de, jgg@nvidia.com, jglisse@redhat.com
Subject: Re: [PATCH v1 05/14] drm/amdkfd: ref count init for device pages
Date: Wed, 25 Aug 2021 10:34:20 -0400 [thread overview]
Message-ID: <9518973c-fe01-9e77-5a5b-e299c3ee3cee@amd.com> (raw)
In-Reply-To: <20210825034828.12927-6-alex.sierra@amd.com>
Am 2021-08-24 um 11:48 p.m. schrieb Alex Sierra:
> Ref counter from device pages is init to zero during memmap init zone.
> The first time a new device page is allocated to migrate data into it,
> its ref counter needs to be initialized to one.
>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index dab290a4d19d..47ee9a895cd2 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -220,7 +220,7 @@ svm_migrate_get_vram_page(struct svm_range *prange, unsigned long pfn)
> page = pfn_to_page(pfn);
> svm_range_bo_ref(prange->svm_bo);
> page->zone_device_data = prange->svm_bo;
> - get_page(page);
There is an assumption here that the page refcount is 0 because the page
should be unused. I'd add a VM_BUG_ON_PAGE(page_ref_count(page), page)
here to check that assumption.
Regards,
Felix
> + init_page_count(page);
> lock_page(page);
> }
>
next prev parent reply other threads:[~2021-08-25 14:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 3:48 [PATCH v1 00/14] Add MEMORY_DEVICE_PUBLIC for CPU-accessible coherent device memory Alex Sierra
2021-08-25 3:48 ` [PATCH v1 01/14] ext4/xfs: add page refcount helper Alex Sierra
2021-08-25 7:35 ` Christoph Hellwig
2021-08-25 15:09 ` Theodore Ts'o
2021-08-25 15:49 ` Darrick J. Wong
2021-08-25 3:48 ` [PATCH v1 02/14] mm: remove extra ZONE_DEVICE struct page refcount Alex Sierra
2021-08-25 7:35 ` Christoph Hellwig
2021-08-25 11:15 ` Vlastimil Babka
2021-08-25 17:49 ` Ralph Campbell
2021-08-27 11:26 ` Vlastimil Babka
2021-08-25 3:48 ` [PATCH v1 03/14] mm: add iomem vma selection for memory migration Alex Sierra
2021-08-25 7:40 ` Christoph Hellwig
2021-08-25 7:46 ` Christoph Hellwig
2021-08-25 18:24 ` Sierra Guiza, Alejandro (Alex)
2021-08-26 22:27 ` Felix Kuehling
2021-08-30 8:28 ` Christoph Hellwig
2021-08-30 17:04 ` Felix Kuehling
2021-09-01 8:29 ` Christoph Hellwig
2021-09-01 15:40 ` Felix Kuehling
2021-09-01 22:03 ` Dave Chinner
2021-09-01 23:07 ` Felix Kuehling
2021-09-02 1:14 ` Dave Chinner
2021-09-09 4:55 ` Felix Kuehling
2021-09-02 8:18 ` Christoph Hellwig
2021-09-02 18:07 ` Dan Williams
2021-09-09 4:02 ` Felix Kuehling
2021-08-25 14:24 ` Felix Kuehling
2021-08-25 3:48 ` [PATCH v1 04/14] mm: add zone device public type memory support Alex Sierra
2021-08-25 3:48 ` [PATCH v1 05/14] drm/amdkfd: ref count init for device pages Alex Sierra
2021-08-25 14:34 ` Felix Kuehling [this message]
2021-08-25 3:48 ` [PATCH v1 06/14] drm/amdkfd: add SPM support for SVM Alex Sierra
2021-08-25 14:45 ` Felix Kuehling
2021-08-25 3:48 ` [PATCH v1 07/14] drm/amdkfd: public type as sys mem on migration to ram Alex Sierra
2021-08-25 3:48 ` [PATCH v1 08/14] mm: add public type support to migrate_vma helpers Alex Sierra
2021-08-25 7:47 ` Christoph Hellwig
2021-08-25 3:48 ` [PATCH v1 09/14] mm: call pgmap->ops->page_free for DEVICE_PUBLIC pages Alex Sierra
2021-08-25 7:46 ` Christoph Hellwig
2021-08-25 3:48 ` [PATCH v1 10/14] lib: test_hmm add ioctl to get zone device type Alex Sierra
2021-08-25 3:48 ` [PATCH v1 11/14] lib: test_hmm add module param for " Alex Sierra
2021-08-25 3:48 ` [PATCH v1 12/14] lib: add support for device public type in test_hmm Alex Sierra
2021-08-25 3:48 ` [PATCH v1 13/14] tools: update hmm-test to support device public type Alex Sierra
2021-08-25 3:48 ` [PATCH v1 14/14] tools: update test_hmm script to support SP config Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9518973c-fe01-9e77-5a5b-e299c3ee3cee@amd.com \
--to=felix.kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).