From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] xfs: Refactor xfs_isilocked()
Date: Thu, 20 Feb 2020 16:25:58 +0000 [thread overview]
Message-ID: <BYAPR04MB5749939FDB825A04AD40D9FF86130@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAJc7PzWrcXpcraAMEfMi6idTeYa9o009tZLOSzp3A6sC-km3DA@mail.gmail.com
On 02/17/2020 02:56 AM, Pavel Reichl wrote:
> On Sat, Feb 15, 2020 at 2:38 AM Chaitanya Kulkarni
> <Chaitanya.Kulkarni@wdc.com> wrote:
>> >
>> >Since it has more than one patch and version 5,
>> >I couldn't find the cover-letter and a change log for this
>> >series, is there a particular reason why it is not present or I
>> >missed it?
>> >
>> >On 02/14/2020 11:00 AM, Pavel Reichl wrote:
>>> > >Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked().
>>> > >__xfs_rwsem_islocked() is a helper function which encapsulates checking
>>> > >state of rw_semaphores hold by inode.
>>> > >
>>> > >
>> >
>> >
> Hi Chaitanya,
>
> sorry for the absence of the changelog I forgot to add it - that was
> not on purpose.
>
> To summarize the changes: I moved the asserts from the first patch to
> the third as suggested by Eric and changed the commit messages as
> suggested by Dave.
Thanks.
>
> Regarding the missing cover-letter it was same since version one and I
> was not sure I should resend it with every new version, should I?
It's okay, it just makes re-viewer's life easier to look for the change.
>
> Thanks you for your comments.
>
> Best regards
>
> Pavel Reichl
>
>
next prev parent reply other threads:[~2020-02-20 16:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:59 [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-02-14 18:59 ` [PATCH v5 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-02-16 22:36 ` Dave Chinner
2020-02-17 13:33 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-02-16 22:37 ` Dave Chinner
2020-02-17 13:34 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-02-16 22:39 ` Dave Chinner
2020-02-17 13:35 ` Christoph Hellwig
2020-02-15 1:38 ` [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Chaitanya Kulkarni
2020-02-17 10:55 ` Pavel Reichl
2020-02-20 16:25 ` Chaitanya Kulkarni [this message]
2020-02-16 22:36 ` Dave Chinner
2020-02-17 13:35 ` Christoph Hellwig
2020-02-19 4:48 ` Darrick J. Wong
2020-02-19 17:31 ` Pavel Reichl
2020-02-19 18:40 ` Christoph Hellwig
2020-02-19 20:16 ` Eric Sandeen
2020-02-20 16:30 ` Pavel Reichl
2020-02-20 16:32 ` Christoph Hellwig
2020-02-20 17:26 ` Eric Sandeen
2020-02-20 17:27 ` Darrick J. Wong
2020-02-21 17:49 ` Pavel Reichl
2020-02-21 20:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5749939FDB825A04AD40D9FF86130@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).