From: Paul Moore <paul@paul-moore.com>
To: Richard Haines <richard_c_haines@btinternet.com>
Cc: darrick.wong@oracle.com, Stephen Smalley <sds@tycho.nsa.gov>,
linux-xfs@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH 1/1] selinux: Add xfs quota command types
Date: Sat, 22 Feb 2020 14:47:27 -0500 [thread overview]
Message-ID: <CAHC9VhSF1Q22tEM2xK4_GUkX5eGaZT25i9Dg6J7TfKrc-jJwLw@mail.gmail.com> (raw)
In-Reply-To: <20200220153234.152426-2-richard_c_haines@btinternet.com>
On Thu, Feb 20, 2020 at 10:32 AM Richard Haines
<richard_c_haines@btinternet.com> wrote:
>
> Add Q_XQUOTAOFF, Q_XQUOTAON and Q_XSETQLIM to trigger filesystem quotamod
> permission check.
>
> Add Q_XGETQUOTA, Q_XGETQSTAT, Q_XGETQSTATV and Q_XGETNEXTQUOTA to trigger
> filesystem quotaget permission check.
>
> Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
> ---
> security/selinux/hooks.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Thanks Richard, I've merged this into selinux/next.
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 46a8f3e7d..974228313 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2145,11 +2145,18 @@ static int selinux_quotactl(int cmds, int type, int id, struct super_block *sb)
> case Q_QUOTAOFF:
> case Q_SETINFO:
> case Q_SETQUOTA:
> + case Q_XQUOTAOFF:
> + case Q_XQUOTAON:
> + case Q_XSETQLIM:
> rc = superblock_has_perm(cred, sb, FILESYSTEM__QUOTAMOD, NULL);
> break;
> case Q_GETFMT:
> case Q_GETINFO:
> case Q_GETQUOTA:
> + case Q_XGETQUOTA:
> + case Q_XGETQSTAT:
> + case Q_XGETQSTATV:
> + case Q_XGETNEXTQUOTA:
> rc = superblock_has_perm(cred, sb, FILESYSTEM__QUOTAGET, NULL);
> break;
> default:
> --
> 2.24.1
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-02-22 19:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:32 [PATCH 0/1] selinux: Add xfs quota command types Richard Haines
2020-02-20 15:32 ` [PATCH 1/1] " Richard Haines
2020-02-20 15:44 ` Christoph Hellwig
2020-02-22 19:47 ` Paul Moore [this message]
2020-02-20 15:57 ` [PATCH 0/1] " Darrick J. Wong
2020-02-20 15:59 ` Christoph Hellwig
[not found] ` <2862d0b2-e0a9-149d-16e5-22c3f5f82e9e@tycho.nsa.gov>
2020-02-20 16:08 ` Christoph Hellwig
2020-02-22 19:49 ` Paul Moore
2020-02-24 16:41 ` Richard Haines
2020-02-25 4:13 ` Darrick J. Wong
2020-02-25 17:54 ` Richard Haines
2020-02-25 21:35 ` Darrick J. Wong
2020-02-26 15:21 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhSF1Q22tEM2xK4_GUkX5eGaZT25i9Dg6J7TfKrc-jJwLw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=richard_c_haines@btinternet.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).