linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	xfs <linux-xfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v2] splice: only read in as much information as there is pipe buffer space
Date: Tue, 17 Sep 2019 15:17:22 +0200	[thread overview]
Message-ID: <CAHpGcM+iYfqniKugC-enWnx+S3KT=8-YtY9RRcr4bVhG8GtkOA@mail.gmail.com> (raw)
In-Reply-To: <20190905034244.GL5340@magnolia>

Am Do., 5. Sept. 2019 um 05:42 Uhr schrieb Darrick J. Wong
<darrick.wong@oracle.com>:
> On Fri, Aug 30, 2019 at 02:06:03PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Andreas Grünbacher reports that on the two filesystems that support
> > iomap directio, it's possible for splice() to return -EAGAIN (instead of
> > a short splice) if the pipe being written to has less space available in
> > its pipe buffers than the length supplied by the calling process.
> >
> > Months ago we fixed splice_direct_to_actor to clamp the length of the
> > read request to the size of the splice pipe.  Do the same to do_splice.
> >
> > Fixes: 17614445576b6 ("splice: don't read more than available pipe space")
> > Reported-by: Andreas Grünbacher <andreas.gruenbacher@gmail.com>
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > v2: tidy up the other call site per Andreas' request
>
> Ping?  Anyone want to add a RVB to this?

You can add the following:

Reviewed-by: Andreas Grünbacher <agruenba@redhat.com>
Tested-by: Andreas Grünbacher <agruenba@redhat.com>

And could you please update the email address in the reported-by tag as well?

Is this going to go in via the xfs tree?

Thanks,
Andreas

  reply	other threads:[~2019-09-17 13:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 16:11 [PATCH] splice: only read in as much information as there is pipe buffer space Darrick J. Wong
2019-08-30  0:44 ` [RFC PATCH] generic: test splice() with pipes Darrick J. Wong
2019-09-02  2:20   ` Zorro Lang
2019-09-02 16:56     ` Darrick J. Wong
2019-09-03  3:19       ` Zorro Lang
2019-11-21 17:01   ` Darrick J. Wong
2019-11-21 18:48     ` Andreas Grünbacher
2019-11-21 19:14       ` Darrick J. Wong
2019-11-22  1:27         ` Andreas Grünbacher
2019-08-30 21:06 ` [PATCH v2] splice: only read in as much information as there is pipe buffer space Darrick J. Wong
2019-09-05  3:42   ` Darrick J. Wong
2019-09-17 13:17     ` Andreas Grünbacher [this message]
2019-09-17 16:46       ` Darrick J. Wong
2019-09-17 17:00         ` Andreas Grünbacher
2019-09-19 22:39           ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHpGcM+iYfqniKugC-enWnx+S3KT=8-YtY9RRcr4bVhG8GtkOA@mail.gmail.com' \
    --to=andreas.gruenbacher@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).