Linux-XFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 1/1] mkfs: Break block discard into chunks of 2 GB
@ 2019-11-27 21:21 Pavel Reichl
  2019-11-28  6:17 ` Pavel Reichl
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Reichl @ 2019-11-27 21:21 UTC (permalink / raw)
  To: linux-xfs; +Cc: Pavel Reichl

Some users are not happy about the BLKDISCARD taking too long and at the same
time not being informed about that - so they think that the command actually
hung.

This commit changes code so that progress reporting is possible and also typing
the ^C will cancel the ongoing BLKDISCARD.

Signed-off-by: Pavel Reichl <preichl@redhat.com>
---
 mkfs/xfs_mkfs.c | 50 ++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 37 insertions(+), 13 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 18338a61..7fa4af0e 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1240,17 +1240,40 @@ done:
 }
 
 static void
-discard_blocks(dev_t dev, uint64_t nsectors)
+discard_blocks(dev_t dev, uint64_t nsectors, int quiet)
 {
-	int fd;
+	int		fd;
+	uint64_t	offset = 0;
+	/* Discard the device 2G at a time */
+	const uint64_t	step = 2ULL << 30;
+	const uint64_t	count = BBTOB(nsectors);
 
-	/*
-	 * We intentionally ignore errors from the discard ioctl.  It is
-	 * not necessary for the mkfs functionality but just an optimization.
-	 */
 	fd = libxfs_device_to_fd(dev);
-	if (fd > 0)
-		platform_discard_blocks(fd, 0, nsectors << 9);
+	if (fd <= 0)
+		return;
+	if (!quiet) {
+		printf("Discarding blocks...");
+		printf("...");
+	}
+
+	/* The block discarding happens in smaller batches so it can be
+	 * interrupted prematurely
+	 */
+	while (offset < count) {
+		uint64_t	tmp_step = min(step, count - offset);
+
+		/*
+		 * We intentionally ignore errors from the discard ioctl. It is
+		 * not necessary for the mkfs functionality but just an
+		 * optimization. However we should stop on error.
+		 */
+		if (platform_discard_blocks(fd, offset, tmp_step))
+			return;
+
+		offset += tmp_step;
+	}
+	if (!quiet)
+		printf("Done.\n");
 }
 
 static __attribute__((noreturn)) void
@@ -2507,18 +2530,19 @@ open_devices(
 
 static void
 discard_devices(
-	struct libxfs_xinit	*xi)
+	struct libxfs_xinit	*xi,
+	int			quiet)
 {
 	/*
 	 * This function has to be called after libxfs has been initialized.
 	 */
 
 	if (!xi->disfile)
-		discard_blocks(xi->ddev, xi->dsize);
+		discard_blocks(xi->ddev, xi->dsize, quiet);
 	if (xi->rtdev && !xi->risfile)
-		discard_blocks(xi->rtdev, xi->rtsize);
+		discard_blocks(xi->rtdev, xi->rtsize, quiet);
 	if (xi->logdev && xi->logdev != xi->ddev && !xi->lisfile)
-		discard_blocks(xi->logdev, xi->logBBsize);
+		discard_blocks(xi->logdev, xi->logBBsize, quiet);
 }
 
 static void
@@ -3749,7 +3773,7 @@ main(
 	 * All values have been validated, discard the old device layout.
 	 */
 	if (discard && !dry_run)
-		discard_devices(&xi);
+		discard_devices(&xi, quiet);
 
 	/*
 	 * we need the libxfs buffer cache from here on in.
-- 
2.23.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 1/1] mkfs: Break block discard into chunks of 2 GB
  2019-11-27 21:21 [PATCH v2 1/1] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
@ 2019-11-28  6:17 ` Pavel Reichl
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Reichl @ 2019-11-28  6:17 UTC (permalink / raw)
  To: linux-xfs

Oh,  I forgot to add '\n' to one of the printf statements. I'll send
fixed patch immediately.

On Wed, Nov 27, 2019 at 10:23 PM Pavel Reichl <preichl@redhat.com> wrote:
>
> Some users are not happy about the BLKDISCARD taking too long and at the same
> time not being informed about that - so they think that the command actually
> hung.
>
> This commit changes code so that progress reporting is possible and also typing
> the ^C will cancel the ongoing BLKDISCARD.
>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> ---
>  mkfs/xfs_mkfs.c | 50 ++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 37 insertions(+), 13 deletions(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 18338a61..7fa4af0e 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -1240,17 +1240,40 @@ done:
>  }
>
>  static void
> -discard_blocks(dev_t dev, uint64_t nsectors)
> +discard_blocks(dev_t dev, uint64_t nsectors, int quiet)
>  {
> -       int fd;
> +       int             fd;
> +       uint64_t        offset = 0;
> +       /* Discard the device 2G at a time */
> +       const uint64_t  step = 2ULL << 30;
> +       const uint64_t  count = BBTOB(nsectors);
>
> -       /*
> -        * We intentionally ignore errors from the discard ioctl.  It is
> -        * not necessary for the mkfs functionality but just an optimization.
> -        */
>         fd = libxfs_device_to_fd(dev);
> -       if (fd > 0)
> -               platform_discard_blocks(fd, 0, nsectors << 9);
> +       if (fd <= 0)
> +               return;
> +       if (!quiet) {
> +               printf("Discarding blocks...");
> +               printf("...");
> +       }
> +
> +       /* The block discarding happens in smaller batches so it can be
> +        * interrupted prematurely
> +        */
> +       while (offset < count) {
> +               uint64_t        tmp_step = min(step, count - offset);
> +
> +               /*
> +                * We intentionally ignore errors from the discard ioctl. It is
> +                * not necessary for the mkfs functionality but just an
> +                * optimization. However we should stop on error.
> +                */
> +               if (platform_discard_blocks(fd, offset, tmp_step))
> +                       return;
> +
> +               offset += tmp_step;
> +       }
> +       if (!quiet)
> +               printf("Done.\n");
>  }
>
>  static __attribute__((noreturn)) void
> @@ -2507,18 +2530,19 @@ open_devices(
>
>  static void
>  discard_devices(
> -       struct libxfs_xinit     *xi)
> +       struct libxfs_xinit     *xi,
> +       int                     quiet)
>  {
>         /*
>          * This function has to be called after libxfs has been initialized.
>          */
>
>         if (!xi->disfile)
> -               discard_blocks(xi->ddev, xi->dsize);
> +               discard_blocks(xi->ddev, xi->dsize, quiet);
>         if (xi->rtdev && !xi->risfile)
> -               discard_blocks(xi->rtdev, xi->rtsize);
> +               discard_blocks(xi->rtdev, xi->rtsize, quiet);
>         if (xi->logdev && xi->logdev != xi->ddev && !xi->lisfile)
> -               discard_blocks(xi->logdev, xi->logBBsize);
> +               discard_blocks(xi->logdev, xi->logBBsize, quiet);
>  }
>
>  static void
> @@ -3749,7 +3773,7 @@ main(
>          * All values have been validated, discard the old device layout.
>          */
>         if (discard && !dry_run)
> -               discard_devices(&xi);
> +               discard_devices(&xi, quiet);
>
>         /*
>          * we need the libxfs buffer cache from here on in.
> --
> 2.23.0
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 21:21 [PATCH v2 1/1] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
2019-11-28  6:17 ` Pavel Reichl

Linux-XFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-xfs/0 linux-xfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-xfs linux-xfs/ https://lore.kernel.org/linux-xfs \
		linux-xfs@vger.kernel.org
	public-inbox-index linux-xfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-xfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git