linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] xfs: Fix xfs_dir2_sf_entry_t size check
Date: Mon, 13 Jan 2020 14:55:15 +0100	[thread overview]
Message-ID: <CAK8P3a0eY6Vm5PNdzR8Min9MrwAqH8vnMZ3C+pxTQhiFVNPyWA@mail.gmail.com> (raw)
In-Reply-To: <435bcb71-9126-b1f1-3803-4977754b36ff@arm.com>

On Thu, Jan 9, 2020 at 10:01 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> Hi Darrick,
>
> On 09/01/2020 16:50, Darrick J. Wong wrote:
> > This sounds like gcc getting confused by the zero length array.  Though
> > it's odd that randconfig breaks, but defconfig doesn't?  This sounds
> > like one of the kernel gcc options causing problems.
> >
>
> This is what I started suspecting as well.

The important bit into the configuration is

# CONFIG_AEABI is not set

With ARM OABI (which you get when EABI is disabled), structures are padded
to multiples of 32 bits. See commits 8353a649f577 ("xfs: kill
xfs_dir2_sf_off_t")
and aa2dd0ad4d6d ("xfs: remove __arch_pack"). Those could be partially
reverted to fix it again, but it doesn't seem worth it as there is
probably nobody
running XFS on OABI machines (actually with the build failure we can
be fairly sure there isn't ;-).

I am testing randconfig builds with OABI and a few other things like ARCH_RPC
disabled because of random issues like this.

      Arnd

  parent reply	other threads:[~2020-01-13 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 14:14 [PATCH] xfs: Fix xfs_dir2_sf_entry_t size check Vincenzo Frascino
2020-01-09 15:01 ` Eric Sandeen
2020-01-09 15:35   ` Vincenzo Frascino
2020-01-09 16:50     ` Darrick J. Wong
     [not found]       ` <435bcb71-9126-b1f1-3803-4977754b36ff@arm.com>
2020-01-13 13:55         ` Arnd Bergmann [this message]
2020-01-13 13:58           ` Christoph Hellwig
2020-01-13 14:06             ` Arnd Bergmann
2020-01-13 17:01               ` Darrick J. Wong
2020-01-13 17:04                 ` Eric Sandeen
2020-01-13 17:26                 ` Vincenzo Frascino
2020-01-13 14:05           ` Vincenzo Frascino
2020-01-12  0:44 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a0eY6Vm5PNdzR8Min9MrwAqH8vnMZ3C+pxTQhiFVNPyWA@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).