From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eryu Guan <guaneryu@gmail.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>, Eryu Guan <guan@eryu.me>
Subject: Re: [PATCH 3/3] new: don't allow new tests in group 'other'
Date: Fri, 17 Sep 2021 13:42:19 +0300 [thread overview]
Message-ID: <CAOQ4uxiTu-b2HAQiFrtbziUKKxKwKjJe2fVnKiVM=AAm_9bXyg@mail.gmail.com> (raw)
In-Reply-To: <163183920637.953189.13037781612178012211.stgit@magnolia>
On Fri, Sep 17, 2021 at 12:57 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> From: Darrick J. Wong <djwong@kernel.org>
>
> The 'other' group is vaguely defined at best -- other than what? It's
> not clear what tests belong in this group, and it has become a dumping
> ground for random stuff that are classified in other groups. Don't let
> people create new other group tests.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> new | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>
> diff --git a/new b/new
> index 3a657d20..9651e0e0 100755
> --- a/new
> +++ b/new
> @@ -100,6 +100,9 @@ check_groups() {
> echo "Invalid characters in group(s): ${inval}"
> echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
> return 1
> + elif [ "${g}" = "other" ]; then
> + echo "Do not add more tests to group \"other\""
> + return 1
> elif ! group_names | grep -q -w "${g}"; then
> echo "Warning: group \"${g}\" not defined in documentation"
> return 1
> @@ -111,16 +114,16 @@ check_groups() {
>
> if [ $# -eq 0 ]; then
> # interactive mode
> - prompt="Add to group(s) [other] (separate by space, ? for list): "
> + prompt="Add to group(s) [auto] (separate by space, ? for list): "
> while true; do
> read -p "${prompt}" -a new_groups || exit 1
> case "${#new_groups[@]}" in
> 0)
> - new_groups=("other")
> + new_groups=("auto")
> ;;
> 1)
> if [ "${new_groups[0]}" = "?" ]; then
> - echo $(group_names)
> + echo $(group_names | grep -v -w 'other')
> continue
> fi
> ;;
>
Darrick,
Thanks for the first cleanup and for this extra cleanup.
I wanted to point out that with this patch there is no implication
to filtering out "other" in group_names() SHOULD you think
this is better. I definitely have no problem with the patch as is!
Thanks,
Amir.
prev parent reply other threads:[~2021-09-17 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 0:39 [PATCHSET 0/3] fstests: various cleanups to ./new script Darrick J. Wong
2021-09-17 0:39 ` [PATCH 1/3] new: clean up the group name input code Darrick J. Wong
2021-09-17 10:28 ` Amir Goldstein
2021-09-17 0:40 ` [PATCH 2/3] new: standardize group name checking Darrick J. Wong
2021-09-17 10:32 ` Amir Goldstein
2021-09-17 0:40 ` [PATCH 3/3] new: don't allow new tests in group 'other' Darrick J. Wong
2021-09-17 10:42 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxiTu-b2HAQiFrtbziUKKxKwKjJe2fVnKiVM=AAm_9bXyg@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).