From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74681C4338F for ; Fri, 20 Aug 2021 22:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B58061154 for ; Fri, 20 Aug 2021 22:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhHTW5p (ORCPT ); Fri, 20 Aug 2021 18:57:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbhHTW5o (ORCPT ); Fri, 20 Aug 2021 18:57:44 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E65C061757 for ; Fri, 20 Aug 2021 15:57:06 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id b9so2416207plx.2 for ; Fri, 20 Aug 2021 15:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G1Z8mu8s2sgn0mbpfu7ra3LWl3tk+2BaXWQ56zeT5Qo=; b=Nt2BeHwjtlSFrM6oUpAp0AEOX1AjgKzHiyuRB0Rdt/NkFHq54pda5iNS/61TJ/a9/M WtZ0MUvUAuWfZAkHqP5am1wnus8fD2MJNtfRLgOK5BYxEamRAJy68cbjkG3kKLjc3e6m 1Ms6ALCk+o8RdYAJUX1suKOU3XJBE72luJok+nKUgFIRJIUiL3D3N2uTn1bOzfRiMLOg KTpdgQvnGWwmB9bFrP9a2SK0ZENdHfLcqPa9QmnSQFNoo7bwvdnxzejlRyQ87R+YTrTU B+QeZ8y+BYNCRMX0yjp8cW2G7BvJIJhPtgqnqBhSC+lI+hPbKn/JWXQ3x6bi1O+SAZol L3iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G1Z8mu8s2sgn0mbpfu7ra3LWl3tk+2BaXWQ56zeT5Qo=; b=uCMFvWfjJcSyXJthSpSHiyLKujQ0n0v8dxSzYhHN5mIbeMoaAcLvhgtay8lgTQJJHz NN4Wcx79U0vpSTFqy0u8TkGnAV+gEqV3D1BTV8Q7zzJS3yC9Lvca4K7x+Wdd5TS5+ONJ reEXzGXvVlVJiIjKFThwPUoDMMUWkGrbLnRrYzhWuGVnLp3pK/hRF6vAHxzJ26hbvjUd vHJ9TkbIfiNAyw3/20NKUt7noq/akpsxrkYUlbAav3aCw8+ywB7WvVQ/82WYENnt/eYK g/eV3AM9+xfX5ImHVi4K1QJkJ30EPqxkEvu37iT2c0MV2aWYc+5ghhmzZ4qDazlgGEZt ZwWA== X-Gm-Message-State: AOAM53132U+zlLvI4rjlnOGKGEYw3EgreFy7sRROlQq+AdfVTrp6HBml jv8eh93pHAMBAbjkS8kOeiQh64kLrEfsqljMyYNpEA== X-Google-Smtp-Source: ABdhPJxmXpLQCDOV4p/qDFeGVDmICU8dPEjZ+Gjrsjl1tuFZXHOKRbvy6d0ZC+yE1xwMVSAlTTyashdIzkFcEanj6Qo= X-Received: by 2002:a17:90b:18f:: with SMTP id t15mr6777302pjs.168.1629500225798; Fri, 20 Aug 2021 15:57:05 -0700 (PDT) MIME-Version: 1.0 References: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> <20210730100158.3117319-7-ruansy.fnst@fujitsu.com> In-Reply-To: From: Dan Williams Date: Fri, 20 Aug 2021 15:56:54 -0700 Message-ID: Subject: Re: [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS To: Jane Chu Cc: Shiyang Ruan , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , device-mapper development , "Darrick J. Wong" , david , Christoph Hellwig , Alasdair Kergon , Mike Snitzer Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Aug 5, 2021 at 5:50 PM Jane Chu wrote: > > > On 7/30/2021 3:01 AM, Shiyang Ruan wrote: > > + mapping = VFS_I(ip)->i_mapping; > > + if (IS_ENABLED(CONFIG_MEMORY_FAILURE)) { > > + for (i = 0; i < rec->rm_blockcount; i++) { > > + error = mf_dax_kill_procs(mapping, rec->rm_offset + i, > > + *flags); > > + if (error) > > + break; > > + } > > + } > > If a poison is injected to a PMD dax page, after consuming the poison, > how many SIGBUS signals are expected to be sent to the process? I think it should only get one. I.e. just like the the generic code does one shootdown per mapped page regardless of whether that page is 4K, 2M, or 1G. Once the application is notified it should be able to query the filesystem to determine the full extent of the damage to files.