From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: failed delalloc conversion results in bad extent lists
Date: Tue, 14 Feb 2023 00:13:19 -0800 [thread overview]
Message-ID: <Y+tCn8owdne7Cbfg@infradead.org> (raw)
In-Reply-To: <20230214055114.4141947-3-david@fromorbit.com>
On Tue, Feb 14, 2023 at 04:51:13PM +1100, Dave Chinner wrote:
> index 958e4bb2e51e..fb718a5825d5 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -4553,8 +4553,12 @@ xfs_bmapi_convert_delalloc(
> * should only happen for the COW fork, where another thread
> * might have moved the extent to the data fork in the meantime.
> */
> - WARN_ON_ONCE(whichfork != XFS_COW_FORK);
> - error = -EAGAIN;
> + if (whichfork != XFS_COW_FORK) {
> + xfs_bmap_mark_sick(ip, whichfork);
> + error = -EFSCORRUPTED;
> + } else {
> + error = -EAGAIN;
> + }
The comment above should probably be expanded a bit on what this means
for a non-cow fork extent and how we'll handle it later.
> + if (error) {
> + if ((error == -EFSCORRUPTED) || (error == -EFSBADCRC))
Nit: no need for the inner braces.
>
> + /*
> + * If the inode is sick, then it might have delalloc extents
> + * within EOF that we were unable to convert. We have to punch
> + * them out here to release the reservation as there is no
> + * longer any data to write back into the delalloc range now.
> + */
> + if (!xfs_inode_is_healthy(ip))
> + xfs_bmap_punch_delalloc_range(ip, 0,
> + i_size_read(VFS_I(ip)));
Is i_size_read the right check here? The delalloc extent could extend
past i_size if i_size is not block aligned. Can't we just simply pass
(xfs_off_t)-1 here?
next prev parent reply other threads:[~2023-02-14 8:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 5:51 [PATCH 0/3] xfs, iomap: fix writeback failure handling Dave Chinner
2023-02-14 5:51 ` [PATCH 1/3] xfs: report block map corruption errors to the health tracking system Dave Chinner
2023-02-14 8:03 ` Christoph Hellwig
2023-02-14 22:21 ` Dave Chinner
2023-02-14 5:51 ` [PATCH 2/3] xfs: failed delalloc conversion results in bad extent lists Dave Chinner
2023-02-14 8:13 ` Christoph Hellwig [this message]
2023-02-14 22:26 ` Dave Chinner
2023-02-14 5:51 ` [PATCH 3/3] xfs, iomap: ->discard_folio() is broken so remove it Dave Chinner
2023-02-14 8:14 ` Christoph Hellwig
2023-02-14 18:10 ` Brian Foster
2023-02-14 22:20 ` Dave Chinner
2023-02-15 1:26 ` Dave Chinner
2023-02-15 15:25 ` Brian Foster
2023-02-15 23:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tCn8owdne7Cbfg@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).