linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/5] xfs: order CIL checkpoint start records
Date: Thu, 12 Aug 2021 08:49:29 +0100	[thread overview]
Message-ID: <YRTSiQz27Prrr8cJ@infradead.org> (raw)
In-Reply-To: <20210810052120.41019-6-david@fromorbit.com>

Looks fine, although I would still prefer xlog_cil_order_write to be split
over the paramter that makes it behave very differently:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2021-08-12  7:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  5:21 [PATCH 0/5 v3] xfs: strictly order log start records Dave Chinner
2021-08-10  5:21 ` [PATCH 1/5] xfs: move xlog_commit_record to xfs_log_cil.c Dave Chinner
2021-08-10  5:21 ` [PATCH 2/5] xfs: pass a CIL context to xlog_write() Dave Chinner
2021-08-10  5:21 ` [PATCH 3/5] xfs: factor out log write ordering from xlog_cil_push_work() Dave Chinner
2021-08-10  5:21 ` [PATCH 4/5] xfs: attach iclog callbacks in xlog_cil_set_ctx_write_state() Dave Chinner
2021-08-10  5:21 ` [PATCH 5/5] xfs: order CIL checkpoint start records Dave Chinner
2021-08-12  7:49   ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-14  3:36 [PATCH 0/5 v2] xfs: strictly order log " Dave Chinner
2021-07-14  3:36 ` [PATCH 5/5] xfs: order CIL checkpoint " Dave Chinner
2021-07-14  6:34   ` Christoph Hellwig
2021-07-14 22:39   ` Darrick J. Wong
2021-06-30  7:21 [PATCH 0/5] xfs: strictly order log " Dave Chinner
2021-06-30  7:21 ` [PATCH 5/5] xfs: order CIL checkpoint " Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRTSiQz27Prrr8cJ@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).