From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE391C4338F for ; Sun, 22 Aug 2021 03:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D64660EB1 for ; Sun, 22 Aug 2021 03:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232251AbhHVDcu (ORCPT ); Sat, 21 Aug 2021 23:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbhHVDcu (ORCPT ); Sat, 21 Aug 2021 23:32:50 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E50C6C061575; Sat, 21 Aug 2021 20:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F3EUlb3R/Jkd83ODBtsIny7A4msWrAlpyjp5NKlJHP0=; b=XPKz3sMtd1ZsLY003mry3sF2zf XiwazOIRt2825xKagpLkvJ5AWVQVQ/LWr1w0hTeTkUHb8WiGA9VxpcKMQAeGzlmdgj/3U+wfuT8p1 cd9zN3pWfQmPyR+9cVcKargExQNQN/ShukVXh0VK1uZqXR5RqIZD66VgWJ53pim66JTeHxbqvn7qG rxii3qRQu0iPlgEx/mmyAJR4eqGhOvYNSu/tIKHys4lAlKwlQWU63/j7M+yfzSS8g49eXWn8Kaaei qcnZWLS+YY0yKmcG6BqNDCe1OEAcnZh6aDGQRLAcENWF9piAwAKv3zcnwh1d0BVeuU4d5lfhoRuZF LN6EniVQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHeBk-008ARv-8l; Sun, 22 Aug 2021 03:30:46 +0000 Date: Sun, 22 Aug 2021 04:30:24 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: Christoph Hellwig , Dave Chinner , xfs , linux-fsdevel Subject: Re: [PATCH] iomap: standardize tracepoint formatting and storage Message-ID: References: <20210822023223.GY12640@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210822023223.GY12640@magnolia> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Aug 21, 2021 at 07:32:23PM -0700, Darrick J. Wong wrote: > @@ -58,8 +58,7 @@ DECLARE_EVENT_CLASS(iomap_range_class, > __entry->offset = off; > __entry->length = len; > ), > - TP_printk("dev %d:%d ino 0x%llx size 0x%llx offset %lx " > - "length %x", > + TP_printk("dev %d:%d ino 0x%llx size 0x%llx offset 0x%llx length 0x%llx", %#llx is one character shorter than 0x%llx ;-)