linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: xs_ig_attempts ??? xs_ig_found + xs_ig_missed
Date: Fri, 27 Aug 2021 07:22:19 +0100	[thread overview]
Message-ID: <YSiEm7ejmZkM4QWq@infradead.org> (raw)
In-Reply-To: <e9072acd-2daa-96da-f1f2-bca7870d6b55@molgen.mpg.de>

On Thu, Aug 26, 2021 at 10:36:41AM +0200, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> In the internal statistics [1] the attempts to look up an inode in the inode
> cache (`xs_ig_attempts`) is a little bigger (35) than the sum of found and
> missed entries minus duplicates (`xfs.inode_ops.ig_dup`): 651067226 =
> 651067191 + 35 > 651067191 = 259143798 + 391923706 - 313.

In addition to the explanation about the counters from data:  all error
returns are also not counted, as well as the case where an
XFS_IGET_INCORE lookup did not find the inode cached.  The latter
would make sense to be included in a missed counter, but it looks like
the counter is more intended to count when an inode is actually read
from disk.

      parent reply	other threads:[~2021-08-27  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26  8:36 xs_ig_attempts ≠ " Paul Menzel
2021-08-26 21:17 ` Dave Chinner
2021-08-27  6:22 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSiEm7ejmZkM4QWq@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --subject='Re: xs_ig_attempts ??? xs_ig_found + xs_ig_missed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).