From: "Theodore Ts'o" <tytso@mit.edu>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Darrick J. Wong" <djwong@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@suse.com>,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] EXT4: Remove ENOMEM/congestion_wait() loops.
Date: Wed, 15 Sep 2021 13:02:29 -0400 [thread overview]
Message-ID: <YUInJQ0wJ4Cd07dT@mit.edu> (raw)
In-Reply-To: <163168354018.3992.580533638417199797@noble.neil.brown.name>
On Wed, Sep 15, 2021 at 03:25:40PM +1000, NeilBrown wrote:
> Adding gfp_mask to __ext4_journal_start_sb() make perfect sense.
> There doesn't seem much point adding one to __ext4_journal_start(),
> we can have ext4_journal_start_with_revoke() call
> __ext4_journal_start_sb() directly.
> But I cannot see what it doesn't already do that.
> i.e. why have the inline __ext4_journal_start() at all?
> Is it OK if I don't use that for ext4_journal_start_with_revoke()?
Sure. I think the only reason why we have __ext4_journal_start() as
an inline function at all was for historical reasons. That is, we
modified __ext4_journal_start() so that it took a struct super, and
instead of changing all of the macros which called
__ext4_journal_start(), we named it to be __ext4_journal_start_sb()
and added the inline definition of __ext4_journal_start() to avoid
changing all of the existing users of __ext4_journal_start().
So sure, it's fine not to use that for
ext4_journal_start_with_revoke(), and we probably should clean up the
use of __ext4_journal_start() at some point. That's unrelated to your
work, though.
Cheers,
- Ted
next prev parent reply other threads:[~2021-09-15 17:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 0:13 [PATCH 0/6] congestion_wait() and GFP_NOFAIL NeilBrown
2021-09-14 0:13 ` [PATCH 2/6] MM: annotate congestion_wait() and wait_iff_congested() as ineffective NeilBrown
2021-09-15 11:56 ` Michal Hocko
2021-09-16 22:13 ` NeilBrown
2021-09-14 0:13 ` [PATCH 5/6] XFS: remove congestion_wait() loop from kmem_alloc() NeilBrown
2021-09-14 1:31 ` Dave Chinner
2021-09-14 3:27 ` NeilBrown
2021-09-14 6:05 ` Dave Chinner
2021-09-14 0:13 ` [PATCH 3/6] EXT4: Remove ENOMEM/congestion_wait() loops NeilBrown
2021-09-14 16:34 ` Mel Gorman
2021-09-14 21:48 ` NeilBrown
2021-09-15 12:06 ` Michal Hocko
2021-09-15 22:35 ` NeilBrown
2021-09-16 0:37 ` Dave Chinner
2021-09-16 6:52 ` Michal Hocko
2021-09-14 23:55 ` Dave Chinner
2021-09-15 8:59 ` Mel Gorman
2021-09-15 12:20 ` Michal Hocko
2021-09-15 14:35 ` Mel Gorman
2021-09-15 22:38 ` Dave Chinner
2021-09-16 9:00 ` Mel Gorman
2021-09-15 0:28 ` Theodore Ts'o
2021-09-15 5:25 ` NeilBrown
2021-09-15 17:02 ` Theodore Ts'o [this message]
2021-09-14 0:13 ` [PATCH 1/6] MM: improve documentation for __GFP_NOFAIL NeilBrown
2021-09-15 11:51 ` Michal Hocko
2021-09-14 0:13 ` [PATCH 6/6] XFS: remove congestion_wait() loop from xfs_buf_alloc_pages() NeilBrown
2021-09-14 2:08 ` Dave Chinner
2021-09-14 2:35 ` NeilBrown
2021-09-14 5:33 ` Dave Chinner
2021-09-14 16:45 ` Mel Gorman
2021-09-14 21:13 ` NeilBrown
2021-09-14 0:13 ` [PATCH 4/6] EXT4: remove congestion_wait from ext4_bio_write_page, and simplify NeilBrown
2021-09-17 2:56 [PATCH 0/6 v2] congestion_wait() and GFP_NOFAIL NeilBrown
2021-09-17 2:56 ` [PATCH 3/6] EXT4: Remove ENOMEM/congestion_wait() loops NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUInJQ0wJ4Cd07dT@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mgorman@suse.com \
--cc=neilb@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).