From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] libfrog: move topology.[ch] to libxfs
Date: Wed, 18 Dec 2019 19:04:32 -0600 [thread overview]
Message-ID: <b48693ed-3c4d-bfc8-c82f-48f871b2dc77@sandeen.net> (raw)
In-Reply-To: <20191219001208.GN7489@magnolia>
On 12/18/19 6:12 PM, Darrick J. Wong wrote:
> On Wed, Dec 18, 2019 at 05:26:44PM -0600, Eric Sandeen wrote:
>> On 12/18/19 5:14 PM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>
>>> The functions in libfrog/topology.c rely on internal libxfs symbols and
>>> functions, so move this file from libfrog to libxfs.
>>
>> None of this is used anywhere but mkfs & repair, and it's not really
>> part of libxfs per se (i.e. it shares nothing w/ kernel code).
>>
>> It used to be in libxcmd. Perhaps it should just be moved back?
>
> But the whole point of getting it out of libxcmd was that it had nothing
> to do with command processing.
Yeah I almost asked that. ;)
> I dunno, I kinda wonder if this should just be libxtopo or something.
bleargh, not sure what it gains us to keep creating little internal libraries,
either.
I guess I don't really care, tbh. Doesn't feel right to shove unrelated stuff
into libxfs/ though, when its main rationale is to share kernel code.
-Eric
next prev parent reply other threads:[~2019-12-19 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 23:14 [PATCH 0/2] libfrog: various small fixes Darrick J. Wong
2019-12-18 23:14 ` [PATCH 1/2] libfrog: remove libxfs.h dependencies in fsgeom.c and linux.c Darrick J. Wong
2019-12-18 23:16 ` Eric Sandeen
2019-12-18 23:14 ` [PATCH 2/2] libfrog: move topology.[ch] to libxfs Darrick J. Wong
2019-12-18 23:26 ` Eric Sandeen
2019-12-19 0:12 ` Darrick J. Wong
2019-12-19 1:04 ` Eric Sandeen [this message]
2020-02-25 19:40 ` Darrick J. Wong
2020-02-26 16:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48693ed-3c4d-bfc8-c82f-48f871b2dc77@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).