From: Pedro Ribeiro <pedrib@gmail.com>
To: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: Bug when mounting XFS with external SATA drives in USB enclosures
Date: Mon, 25 Nov 2019 09:30:05 +0700 [thread overview]
Message-ID: <ba5d4b63-84f7-c818-460d-44a421039526@gmail.com> (raw)
In-Reply-To: <9ee09a97-b3a1-7bf9-43f2-ed2b47e35dc5@sandeen.net>
On 25/11/2019 02:16, Eric Sandeen wrote:
> Hm that doesn't make sense; f8f9ee479439 introduces kmem_alloc_io
> with 3 arguments. 2 arguments to kmem_alloc_io, missing the alignment
> mask, would be a problem.
>
>> return kmem_alloc_io(BBTOB(nbblks), align_mask, KM_MAYFAIL | KM_ZERO);
>> return kmem_alloc_io(BBTOB(nbblks), KM_MAYFAIL | KM_ZERO);
>>
>> Do you think it's safe to keep these 4 patches on top of the 5.3.12
>> tree? So far it all looks fine, filesystems mount and work fine.
>
> Yes, but ... they should probably be applied correctly. A quick test here
> seems to show the three I suggested apply to 5.3.12 cleanly.
>
> -Eric
>
You're right, my bad, I applied them in order and now they work fine. I
guess there's no point in fixing this in stable since 5.3 is not a long
term kernel and the fix is already in 5.4?
Regards,
Pedro
prev parent reply other threads:[~2019-11-25 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 3:21 Bug when mounting XFS with external SATA drives in USB enclosures Pedro Ribeiro
2019-11-23 16:56 ` Chris Murphy
2019-11-23 18:12 ` Pedro Ribeiro
2019-11-23 18:26 ` Eric Sandeen
2019-11-24 6:49 ` Pedro Ribeiro
2019-11-24 19:16 ` Eric Sandeen
2019-11-25 2:30 ` Pedro Ribeiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba5d4b63-84f7-c818-460d-44a421039526@gmail.com \
--to=pedrib@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).