From: firstname.lastname@example.org To: email@example.com Subject: [Bug 206397] [xfstests generic/475] XFS: Assertion failed: iclog->ic_state == XLOG_STATE_ACTIVE, file: fs/xfs/xfs_log.c, line: 572 Date: Fri, 14 Feb 2020 18:18:44 +0000 Message-ID: <bug-206397-201763-tzSTAiArGr@https.bugzilla.kernel.org/> (raw) In-Reply-To: <firstname.lastname@example.org/> https://bugzilla.kernel.org/show_bug.cgi?id=206397 --- Comment #4 from email@example.com --- On Wed, Feb 12, 2020 at 10:55:10AM -0500, Brian Foster wrote: > On Tue, Feb 04, 2020 at 05:10:05PM +0000, firstname.lastname@example.org > wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=206397 > > > > --- Comment #2 from Zorro Lang (email@example.com) --- > > (In reply to Chandan Rajendra from comment #1) > > > I was unable to recreate this issue on a ppc64le kvm guest. I used Linux > > > v5.5 and xfsprogs' for-next branch. > > > > > > Can you please share the kernel config file? Also, Can you please tell me > > > how easy is it recreate this bug? > > > > It's really hard to reproduce. The g/475 is a random test, it's helped us > to > > find many different issues. For this bug, this's the 1st time I hit it, and > > can't reproduce it simply. > > > > Have you still been unable to reproduce (assuming you've been attempting > to)? How many iterations were required before you reproduced the first > time? > > I'm wondering if the XLOG_STATE_IOERROR check in xfs_log_release_iclog() > is racy with respect to filesystem shutdown. There's an ASSERT_ALWAYS() > earlier in this (xlog_cil_push()) codepath that checks for ACTIVE || > WANT_SYNC and it doesn't appear that has failed from your output > snippet. The aforementioned IOERROR check occurs before we acquire > ->l_icloglock, however, which I think means xfs_log_force_umount() could > jump in if called from another task and reset all of the iclogs while > the release path waits on the lock. > FWIW, I wasn't able to reproduce after a day or so of iterating generic/475, but I was able to confirm that the check referenced above is racy. The problem looks like a minor oversight in commit df732b29c8 ("xfs: call xlog_state_release_iclog with l_icloglock held"). I've floated a patch here: https://firstname.lastname@example.org/ Brian > Brian > > > -- > > You are receiving this mail because: > > You are watching the assignee of the bug. > > > -- You are receiving this mail because: You are watching the assignee of the bug.
prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-04 3:44 [Bug 206397] New: " bugzilla-daemon 2020-02-04 13:48 ` [Bug 206397] " bugzilla-daemon 2020-02-04 17:10 ` bugzilla-daemon 2020-02-12 15:55 ` Brian Foster 2020-02-14 18:18 ` Brian Foster 2020-02-12 15:57 ` bugzilla-daemon 2020-02-14 18:18 ` bugzilla-daemon [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-206397-201763-tzSTAiArGr@https.bugzilla.kernel.org/ \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-XFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-xfs/0 linux-xfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-xfs linux-xfs/ https://lore.kernel.org/linux-xfs \ email@example.com public-inbox-index linux-xfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-xfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git