From: Eric Sandeen <sandeen@sandeen.net>
To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: hch@lst.de
Subject: Re: [PATCH 0/3] iomap: 1 cleanup, 1 fix, 1 optimization
Date: Thu, 13 Dec 2018 16:27:25 -0600 [thread overview]
Message-ID: <c9b9324d-9ec6-7d2b-360d-e462fa80c2bf@sandeen.net> (raw)
In-Reply-To: <1544739929-21651-1-git-send-email-sandeen@sandeen.net>
On 12/13/18 4:25 PM, Eric Sandeen wrote:
> Patch 1 is trivial, to use the SECTOR_SIZE macro instead of open-coding.
> Patch 2 is the one that matters: iomap_is_partially_uptodate was doing invalid memory accesses past the end of the iomap_page->uptodate bitmap.
> Patch3 is a small optimization (?) based on what the non-iomap code does, i.e. don't bother checking each block if the "partial" range covers the whole page
>
> These survived an xfstests -g auto run on 4k and 1k block size filesystems
> on x86_64. Careful review for off by ones is appreciated in any case. ;)
Ugh, I fatfingered a cc (or maybe I'll blame guilt) - careful on reply-all,
sorry about that.
-Eric
prev parent reply other threads:[~2018-12-13 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 22:25 [PATCH 0/3] iomap: 1 cleanup, 1 fix, 1 optimization Eric Sandeen
2018-12-13 22:25 ` [PATCH 1/3] iomap: use SECTOR_SIZE instead of 512 in iomap_page Eric Sandeen
2018-12-15 10:51 ` Christoph Hellwig
2018-12-17 23:45 ` Eric Sandeen
2018-12-18 18:06 ` Christoph Hellwig
2018-12-18 18:19 ` Darrick J. Wong
2018-12-18 18:20 ` Eric Sandeen
2018-12-13 22:25 ` [PATCH 2/3] iomap: don't search past page end in iomap_is_partially_uptodate Eric Sandeen
2018-12-14 2:57 ` Dave Chinner
2018-12-14 13:48 ` Eric Sandeen
2018-12-14 22:14 ` [PATCH 2/3 V2] mm: don't search past page end in is_partially_uptodate Eric Sandeen
2018-12-15 10:49 ` Christoph Hellwig
2018-12-13 22:25 ` [PATCH 3/3] iomap: optimize iomap_is_partially_uptodate for full page range Eric Sandeen
2018-12-14 3:05 ` Dave Chinner
2018-12-14 14:10 ` Eric Sandeen
2018-12-17 23:21 ` Dave Chinner
2018-12-13 22:27 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b9324d-9ec6-7d2b-360d-e462fa80c2bf@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).