From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>, John Jore <john@jore.no>
Subject: Re: [PATCH] xfs_repair: fix bad next_unlinked field
Date: Tue, 11 Feb 2020 08:34:00 -0600 [thread overview]
Message-ID: <daca5723-5631-31f8-a163-bc024d8b7111@redhat.com> (raw)
In-Reply-To: <20200211090836.cims7r4jvrds2e7w@andromeda>
On 2/11/20 3:08 AM, Carlos Maiolino wrote:
>> + unlinked_ino = be32_to_cpu(dino->di_next_unlinked);
>> + if (!xfs_verify_agino_or_null(mp, agno, unlinked_ino)) {
>> + retval = 1;
>> + if (!uncertain)
>> + do_warn(_("bad next_unlinked 0x%x on inode %" PRIu64 "%c"),
>> + (__s32)dino->di_next_unlinked, lino,
> ^^^^
> shouldn't we be using be32_to_cpu()
> here, instead of a direct casting to
> __s32?
Yes, good catch. I was looking at the version check which just does (__s8)
but of course that doesn't need the conversion. I'll fix it here, thanks!
-Eric
next prev parent reply other threads:[~2020-02-11 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 15:42 [PATCH] xfs_repair: fix bad next_unlinked field Eric Sandeen
2020-02-10 15:54 ` Darrick J. Wong
2020-02-11 9:08 ` Carlos Maiolino
2020-02-11 14:34 ` Eric Sandeen [this message]
2020-02-11 10:11 ` John Jore
2020-02-11 14:31 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daca5723-5631-31f8-a163-bc024d8b7111@redhat.com \
--to=sandeen@redhat.com \
--cc=john@jore.no \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).