From: Eric Sandeen <sandeen@sandeen.net>
To: Stefan Ring <stefanrin@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Try to squash metadump data leaks
Date: Fri, 26 Oct 2018 07:36:28 -0500 [thread overview]
Message-ID: <db5b1207-0b8f-cbc6-370f-c2c9d07e8407@sandeen.net> (raw)
In-Reply-To: <CAAxjCEwKqkK6RuE34tXXW=hZXyw5JsU2bhVh73ZRfyW2rGxmXQ@mail.gmail.com>
On 10/26/18 12:29 AM, Stefan Ring wrote:
> On Fri, Oct 26, 2018 at 2:36 AM Eric Sandeen <sandeen@sandeen.net> wrote:
>>> Hm, I think another case we're missing is interior nodes on multi-fsb objects,
>> i.e. everything under /* Zero unused part of interior nodes */ seems to be
>> missing for the process_multi_fsb_objects case as well. Urk, what a mess.
>
> It is a classic game of whack-a-mole ;). I do understand that it is
> this way for historical reasons, but if it would be redone today, it
> should obviously use zeroed buffers for writing out and copy just the
> bits that are known to be needed.
Yeah, I was thinking about that last night. I'm not sure it'd be a whole
lot easier, though - for every single type of metadata block we either
need to zap the holes or copy the bits, but every boundary is the same
and would need to be computed and handled regardless.
I'm not sure it'd be a win.
-Eric
next prev parent reply other threads:[~2018-10-26 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:44 [PATCH v3 0/2] Try to squash metadump data leaks Stefan Ring
2018-10-11 19:44 ` [PATCH 1/2] xfs_metadump: Extend zapping to multi fsb dir blocks Stefan Ring
2018-10-23 15:10 ` Eric Sandeen
2018-10-25 15:08 ` Eric Sandeen
2018-10-25 16:44 ` Stefan Ring
2018-10-11 19:44 ` [PATCH 2/2] xfs_metadump: Zap more stale data Stefan Ring
2018-10-23 15:49 ` Darrick J. Wong
2018-10-25 16:42 ` Stefan Ring
2018-10-26 20:23 ` Stefan Ring
2018-10-26 5:32 ` Stefan Ring
2018-10-25 15:50 ` [PATCH v3 0/2] Try to squash metadump data leaks Eric Sandeen
2018-10-26 0:36 ` Eric Sandeen
2018-10-26 5:29 ` Stefan Ring
2018-10-26 12:36 ` Eric Sandeen [this message]
2018-10-26 18:37 ` Stefan Ring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db5b1207-0b8f-cbc6-370f-c2c9d07e8407@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-xfs@vger.kernel.org \
--cc=stefanrin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).