From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, alex@zadara.com
Subject: Re: [PATCH 3/6] xfs_repair: refactor fixed inode location checks
Date: Thu, 30 Jan 2020 13:52:49 -0600 [thread overview]
Message-ID: <e218b1e2-37a1-4730-7ec4-897d1f275c9e@sandeen.net> (raw)
In-Reply-To: <eb751e4d-aaea-2c47-4297-d844abfac75b@sandeen.net>
On 1/30/20 1:45 PM, Eric Sandeen wrote:
> On 1/23/20 6:17 PM, Darrick J. Wong wrote:
>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>
>> Refactor the checking and resetting of fixed-location inodes (root,
>> rbmino, rsumino) into a helper function.
>>
>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Looks good, though it might mess with translations a bit?
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Actually, would you mind if I changed "ensure_fixed_ino" to something
like "check_inode_loc" or "validate_inode_nr" ... I don't know what
it means to "ensure" an inode. :)
Not a huge deal but if there's something more descriptive, let's use
it.
-Eric
next prev parent reply other threads:[~2020-01-30 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 0:17 [PATCH v3 0/6] xfs_repair: do not trash valid root dirs Darrick J. Wong
2020-01-24 0:17 ` [PATCH 1/6] mkfs: check root inode location Darrick J. Wong
2020-01-30 19:32 ` Eric Sandeen
2020-01-30 20:19 ` Darrick J. Wong
2020-01-30 20:34 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 2/6] xfs_repair: enforce that inode btree chunks can't point to AG headers Darrick J. Wong
2020-01-30 19:38 ` Eric Sandeen
2020-01-30 20:26 ` Darrick J. Wong
2020-01-30 20:46 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 3/6] xfs_repair: refactor fixed inode location checks Darrick J. Wong
2020-01-30 19:45 ` Eric Sandeen
2020-01-30 19:52 ` Eric Sandeen [this message]
2020-01-24 0:17 ` [PATCH 4/6] xfs_repair: use libxfs function to calculate root inode location Darrick J. Wong
2020-01-30 19:48 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 5/6] xfs_repair: check plausibility of root dir pointer before trashing it Darrick J. Wong
2020-01-30 20:18 ` Eric Sandeen
2020-01-30 20:34 ` Darrick J. Wong
2020-01-30 20:41 ` Eric Sandeen
2020-01-30 20:50 ` Darrick J. Wong
2020-01-24 0:18 ` [PATCH 6/6] xfs_repair: try to correct sb_unit value from secondaries Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-01-01 1:20 [PATCH v2 0/6] xfs_repair: do not trash valid root dirs Darrick J. Wong
2020-01-01 1:21 ` [PATCH 3/6] xfs_repair: refactor fixed inode location checks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e218b1e2-37a1-4730-7ec4-897d1f275c9e@sandeen.net \
--to=sandeen@sandeen.net \
--cc=alex@zadara.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).