From: Randy Dunlap <rdunlap@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] iomap: Fix some typos and bad grammar
Date: Mon, 2 Aug 2021 15:33:48 -0700 [thread overview]
Message-ID: <e29cdfb5-d203-adb0-b421-53f2339cb91e@infradead.org> (raw)
In-Reply-To: <CAHc6FU66B9VJFu6tPvDMJZYPbgGoytf3zR1yxRfg92Zw1=vaCQ@mail.gmail.com>
On 8/2/21 3:16 PM, Andreas Gruenbacher wrote:
> On Tue, Aug 3, 2021 at 12:13 AM Darrick J. Wong <djwong@kernel.org> wrote:
>> On Sun, Aug 01, 2021 at 02:00:58PM +0200, Andreas Gruenbacher wrote:
>>> Fix some typos and bad grammar in buffered-io.c to make the comments
>>> easier to read.
>>>
>>> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>>
>> Looks good to me, though I'm less enthused about the parts of the diff
>> that combine words into contractions.
fwiw, I don't much care for them either.
> Feel free to adjust as you see fit.
>
>> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> Thanks,
> Andreas
>
--
~Randy
prev parent reply other threads:[~2021-08-02 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 12:00 [PATCH] iomap: Fix some typos and bad grammar Andreas Gruenbacher
2021-08-02 22:13 ` Darrick J. Wong
2021-08-02 22:16 ` Andreas Gruenbacher
2021-08-02 22:33 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29cdfb5-d203-adb0-b421-53f2339cb91e@infradead.org \
--to=rdunlap@infradead.org \
--cc=agruenba@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).