linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/8] libxfs: remove duplicate attr function declarations
Date: Thu, 30 Jan 2020 12:48:41 -0600	[thread overview]
Message-ID: <e910d8f5-1b3b-7090-b613-47ac7cf1cb92@sandeen.net> (raw)
In-Reply-To: <20200130184007.GB3447196@magnolia>



On 1/30/20 12:40 PM, Darrick J. Wong wrote:
> On Thu, Jan 30, 2020 at 12:28:43PM -0600, Eric Sandeen wrote:
>> On 1/30/20 12:13 PM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>
>>> Remove these function declarations since they're in libxfs/xfs_attr.h
>>> and are therefore redundant.
>>>
>>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>>
>> Is it worth keeping this exporting hack around to make static checkers
>> happy if it's just one more thing to keep up to date in userspace?
> 
> Probably?  It depends on how much you like culling known false positives
> when you run smatch/sparse against xfsprogs.
> 
> (I for one don't mind not having to remember that stuff...)

Ok.  I'm wondering how you guys happened to notice the dups.

Seems like

bool xfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);

can be removed as well, FWIW.

-Eric

  reply	other threads:[~2020-01-30 18:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24  0:16 [PATCH 0/8] xfsprogs: random fixes Darrick J. Wong
2020-01-24  0:16 ` [PATCH 1/8] man: list xfs_io lsattr inode flag letters Darrick J. Wong
2020-01-25 23:16   ` Christoph Hellwig
2020-01-24  0:16 ` [PATCH 2/8] man: document the xfs_db btheight command Darrick J. Wong
2020-01-25 23:16   ` Christoph Hellwig
2020-01-24  0:16 ` [PATCH 3/8] man: reformat xfs_quota commands in the manpage for testing Darrick J. Wong
2020-01-25 23:16   ` Christoph Hellwig
2020-01-24  0:16 ` [PATCH 4/8] man: document some missing xfs_db commands Darrick J. Wong
2020-01-25 23:16   ` Christoph Hellwig
2020-01-24  0:17 ` [PATCH 5/8] xfs_db: dump per-AG reservations Darrick J. Wong
2020-01-25 23:17   ` Christoph Hellwig
2020-01-24  0:17 ` [PATCH 6/8] xfs_io: fix copy_file_range length argument overflow Darrick J. Wong
2020-01-25 23:18   ` Christoph Hellwig
2020-01-24  0:17 ` [PATCH 7/8] xfs_io: fix pwrite/pread length truncation on 32-bit systems Darrick J. Wong
2020-01-25 23:18   ` Christoph Hellwig
2020-01-24  0:17 ` [PATCH 8/8] xfs_repair: fix totally broken unit conversion in directory invalidation Darrick J. Wong
2020-01-25 23:19   ` Christoph Hellwig
2020-01-26 22:11     ` Darrick J. Wong
2020-01-30 18:35       ` Eric Sandeen
2020-01-28 15:56 ` [PATCH 9/8] xfs_io: fix integer over/underflow handling in timespec_from_string Darrick J. Wong
2020-01-30 18:18   ` Christoph Hellwig
2020-01-30 18:13 ` [PATCH 10/8] libxfs: remove duplicate attr function declarations Darrick J. Wong
2020-01-30 18:17   ` Christoph Hellwig
2020-01-30 18:28   ` Eric Sandeen
2020-01-30 18:40     ` Darrick J. Wong
2020-01-30 18:48       ` Eric Sandeen [this message]
2020-01-30 18:15 ` [PATCH 11/8] xfs_repair: don't corrupt a attr fork da3 node when clearing forw/back Darrick J. Wong
2020-01-30 18:22   ` Christoph Hellwig
2020-01-30 18:31     ` Darrick J. Wong
2020-01-30 18:46   ` [PATCH v2 " Darrick J. Wong
2020-01-31  6:03     ` Christoph Hellwig
2020-02-04 23:14       ` Darrick J. Wong
2020-02-05  6:07         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e910d8f5-1b3b-7090-b613-47ac7cf1cb92@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).