From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 04/11] xfs_scrub: improve reporting of file metadata media errors
Date: Mon, 21 Oct 2019 11:53:19 -0500 [thread overview]
Message-ID: <ee46dce3-e295-3e17-9ada-e64aef0a94b9@sandeen.net> (raw)
In-Reply-To: <156944739208.300131.5955900694911585741.stgit@magnolia>
On 9/25/19 4:36 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Report media errors that map to data and attr fork extent maps.
Ok so I think the last patch removed reporting on files but this adds it
back...
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> scrub/phase6.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
> diff --git a/scrub/phase6.c b/scrub/phase6.c
> index 310ab36c..1013ba6d 100644
> --- a/scrub/phase6.c
> +++ b/scrub/phase6.c
> @@ -385,6 +385,17 @@ xfs_check_rmap_error_report(
> str_error(ctx, buf, _("media error in %s."), type);
> }
>
> + /* Report extent maps */
> + if (map->fmr_flags & FMR_OF_EXTENT_MAP) {
> + bool attr = (map->fmr_flags & FMR_OF_ATTR_FORK);
> +
> + scrub_render_ino_suffix(ctx, buf, DESCR_BUFSZ,
> + map->fmr_owner, 0, " %s",
> + attr ? _("extended attribute") :
> + _("file data"));
> + str_error(ctx, buf, _("media error in extent map"));
> + }
> +
> /*
> * XXX: If we had a getparent() call we could report IO errors
> * efficiently. Until then, we'll have to scan the dir tree
>
next prev parent reply other threads:[~2019-10-21 16:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 21:36 [PATCH 00/11] xfs_scrub: fix IO error reporting Darrick J. Wong
2019-09-25 21:36 ` [PATCH 01/11] xfs_scrub: separate media error reporting for attribute forks Darrick J. Wong
2019-10-21 16:18 ` Eric Sandeen
2019-10-21 17:32 ` Darrick J. Wong
2019-09-25 21:36 ` [PATCH 02/11] xfs_scrub: improve reporting of file data media errors Darrick J. Wong
2019-10-21 16:33 ` Eric Sandeen
2019-10-21 17:56 ` Darrick J. Wong
2019-09-25 21:36 ` [PATCH 03/11] xfs_scrub: better reporting of metadata " Darrick J. Wong
2019-10-21 16:46 ` Eric Sandeen
2019-10-21 18:10 ` Darrick J. Wong
2019-09-25 21:36 ` [PATCH 04/11] xfs_scrub: improve reporting of file " Darrick J. Wong
2019-10-21 16:53 ` Eric Sandeen [this message]
2019-09-25 21:36 ` [PATCH 05/11] xfs_scrub: don't report media errors on unwritten extents Darrick J. Wong
2019-10-21 16:54 ` Eric Sandeen
2019-09-25 21:36 ` [PATCH 06/11] xfs_scrub: reduce fsmap activity for media errors Darrick J. Wong
2019-10-21 17:17 ` Eric Sandeen
2019-10-21 18:14 ` Darrick J. Wong
2019-09-25 21:36 ` [PATCH 07/11] xfs_scrub: request fewer bmaps when we can Darrick J. Wong
2019-10-21 18:05 ` Eric Sandeen
2019-10-21 18:15 ` Darrick J. Wong
2019-09-25 21:36 ` [PATCH 08/11] xfs_scrub: fix media verification thread pool size calculations Darrick J. Wong
2019-10-21 19:28 ` Eric Sandeen
2019-09-25 21:37 ` [PATCH 09/11] libfrog: clean up platform_nproc Darrick J. Wong
2019-10-21 19:31 ` Eric Sandeen
2019-10-21 20:13 ` Darrick J. Wong
2019-09-25 21:37 ` [PATCH 10/11] xfs_scrub: clean out the nproc global variable Darrick J. Wong
2019-10-21 19:32 ` Eric Sandeen
2019-09-25 21:37 ` [PATCH 11/11] xfs_scrub: create a new category for unfixable errors Darrick J. Wong
2019-10-21 19:45 ` Eric Sandeen
2019-10-21 20:29 ` Darrick J. Wong
2019-10-21 20:38 ` Eric Sandeen
-- strict thread matches above, loose matches on Subject: below --
2019-09-06 3:38 [PATCH 00/11] xfs_scrub: fix IO error reporting Darrick J. Wong
2019-09-06 3:39 ` [PATCH 04/11] xfs_scrub: improve reporting of file metadata media errors Darrick J. Wong
2019-08-26 21:31 [PATCH 00/11] xfs_scrub: fix IO error reporting Darrick J. Wong
2019-08-26 21:31 ` [PATCH 04/11] xfs_scrub: improve reporting of file metadata media errors Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee46dce3-e295-3e17-9ada-e64aef0a94b9@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).