From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7629C43331 for ; Tue, 26 Jan 2021 05:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A59622D04 for ; Tue, 26 Jan 2021 05:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729344AbhAZFSL (ORCPT ); Tue, 26 Jan 2021 00:18:11 -0500 Received: from sandeen.net ([63.231.237.45]:37226 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729377AbhAYOUM (ORCPT ); Mon, 25 Jan 2021 09:20:12 -0500 Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id 851E85EDAB; Mon, 25 Jan 2021 08:17:37 -0600 (CST) To: Chandan Babu R , linux-xfs@vger.kernel.org References: <20210125095809.219833-1-chandanrlinux@gmail.com> <20210125095809.219833-2-chandanrlinux@gmail.com> From: Eric Sandeen Subject: Re: [PATCH 2/2] xfsprogs: xfs_fsr: Limit the scope of cmp() Message-ID: Date: Mon, 25 Jan 2021 08:19:30 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210125095809.219833-2-chandanrlinux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 1/25/21 3:58 AM, Chandan Babu R wrote: > cmp() function is being referred to by only from within fsr/xfs_fsr.c. Hence > this commit limits its scope to the current file. > > Signed-off-by: Chandan Babu R Might be nice to move cmp just ahead of fsrfs() so we don't need the forward declaration but *shrug* Reviewed-by: Eric Sandeen > --- > fsr/xfs_fsr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c > index 635e4c70..2d070320 100644 > --- a/fsr/xfs_fsr.c > +++ b/fsr/xfs_fsr.c > @@ -81,7 +81,7 @@ char * gettmpname(char *fname); > char * getparent(char *fname); > int fsrprintf(const char *fmt, ...); > int read_fd_bmap(int, struct xfs_bstat *, int *); > -int cmp(const void *, const void *); > +static int cmp(const void *, const void *); > static void tmp_init(char *mnt); > static char * tmp_next(char *mnt); > static void tmp_close(char *mnt); > @@ -699,7 +699,7 @@ out0: > /* > * To compare bstat structs for qsort. > */ > -int > +static int > cmp(const void *s1, const void *s2) > { > return( ((struct xfs_bulkstat *)s2)->bs_extents - >