From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435E8C5519F for ; Tue, 17 Nov 2020 18:18:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E1E722210 for ; Tue, 17 Nov 2020 18:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730352AbgKQSSL (ORCPT ); Tue, 17 Nov 2020 13:18:11 -0500 Received: from sandeen.net ([63.231.237.45]:60730 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730914AbgKQSSK (ORCPT ); Tue, 17 Nov 2020 13:18:10 -0500 Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id 075192420; Tue, 17 Nov 2020 12:17:45 -0600 (CST) To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org References: <160375524618.881414.16347303401529121282.stgit@magnolia> <160375537615.881414.8162037930017365466.stgit@magnolia> <20201117174521.GY9695@magnolia> From: Eric Sandeen Subject: Re: [PATCH v2 20/26] xfs_db: report bigtime format timestamps Message-ID: Date: Tue, 17 Nov 2020 12:18:09 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201117174521.GY9695@magnolia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 11/17/20 11:45 AM, Darrick J. Wong wrote: > From: Darrick J. Wong > > Report the large format timestamps in a human-readable manner if it is > possible to do so without loss of information. > > Signed-off-by: Darrick J. Wong > --- > v2: skip the build bug stuff and check directly for information loss in > the time64_t -> time_t conversion This looks reasonable to me. Thanks for working this all out. Reviewed-by: Eric Sandeen