From: Ian Kent <raven@themaw.net>
To: Eric Sandeen <sandeen@sandeen.net>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfsprogs: ignore autofs mount table entries
Date: Fri, 02 Oct 2020 12:40:06 +0800 [thread overview]
Message-ID: <f2dbe235ba34db4568e93c87edcd529a606e20ce.camel@themaw.net> (raw)
In-Reply-To: <200b30f514e30ecaebb754efb8a8ea5cb4d38fd3.camel@themaw.net>
On Fri, 2020-10-02 at 10:27 +0800, Ian Kent wrote:
> On Thu, 2020-10-01 at 16:22 -0500, Eric Sandeen wrote:
snip ...
> >
> > Backing up a bit, which xfsprogs utility saw this behavior with
> > autofs mounts?
>
> IIRC the problem I saw ended up being with xfs_spaceman invoked
> via udisksd on mount/umount activity. There may be other cases so
> I'd rather not assume there won't be problems elsewhere but those
> checks for an xfs fs that I didn't notice probably need to change.
Looking around further, there may be another assumption that's
not right.
It looks like xfs_info is being called via udisksd -> libblockdev
and the xfd_open() triggers the mount not a statfs() call as thought.
I can't see why I saw xfs_spaceman hanging around longer than I
thought it should so I probably don't have the full story.
It's a bit academic though because there are good reasons to ignore
autofs mounts in the libfrog functions, platform_check_mount()
and fs_table_initialise_mounts().
If an autofs user has large direct mount maps there can be thousands
of distinct mount table entries which, mostly, if not always, serve
no useful purpose to utilities. They just add overhead so getting rid
of them at the earliest opportunity is the sensible thing to do.
In fact, before the mtab was symlinked to the proc mount table, I
simply didn't update the mount table for autofs fs mounts so they
never appeared and there were never any problem reports due to doing
this.
I could go on (and on) about this, but I'm starting to digress ...
Ian
next prev parent reply other threads:[~2020-10-02 4:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 1:06 [PATCH] xfsprogs: ignore autofs mount table entries Ian Kent
2020-10-01 15:19 ` Darrick J. Wong
2020-10-02 2:55 ` Ian Kent
2020-10-01 21:22 ` Eric Sandeen
2020-10-02 2:27 ` Ian Kent
2020-10-02 4:40 ` Ian Kent [this message]
2020-10-08 20:02 ` Eric Sandeen
2020-10-09 0:55 ` Ian Kent
2020-10-02 15:15 ` Eric Sandeen
2020-10-07 4:41 ` Ian Kent
2020-10-08 1:52 Ian Kent
2020-10-08 1:54 ` Ian Kent
2020-10-08 20:03 ` Eric Sandeen
2020-10-09 0:49 ` Ian Kent
2020-10-15 8:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2dbe235ba34db4568e93c87edcd529a606e20ce.camel@themaw.net \
--to=raven@themaw.net \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).