linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <djwong@kernel.org>,
	Bill O'Donnell <bodonnel@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: dax: facilitate EXPERIMENTAL warning for dax=inode case
Date: Thu, 26 Aug 2021 13:16:22 -0500	[thread overview]
Message-ID: <f6ddf52a-0b85-665a-115e-106242b1af95@sandeen.net> (raw)
In-Reply-To: <20210826180947.GL12640@magnolia>


On 8/26/21 1:09 PM, Darrick J. Wong wrote:
> On Thu, Aug 26, 2021 at 12:30:12PM -0500, Bill O'Donnell wrote:

>> @@ -1584,7 +1586,7 @@ xfs_fs_fill_super(
>>   	if (xfs_has_crc(mp))
>>   		sb->s_flags |= SB_I_VERSION;
>>   
>> -	if (xfs_has_dax_always(mp)) {
>> +	if (xfs_has_dax_always(mp) || xfs_has_dax_inode(mp)) {
> 
> Er... can't this be done without burning another feature bit by:
> 
> 	if (xfs_has_dax_always(mp) || (!xfs_has_dax_always(mp) &&
> 				       !xfs_has_dax_never(mp))) {
> 		...
> 		xfs_warn(mp, "DAX IS EXPERIMENTAL");
> 	}

changing this conditional in this way will also fail dax=inode mounts on
reflink-capable (i.e. default) filesystems, no?

-	if (xfs_has_dax_always(mp)) {
+	if (xfs_has_dax_always(mp) || $NEW_DAX_INODE_TEST) {

...
                 if (xfs_has_reflink(mp)) {
                         xfs_alert(mp,
                 "DAX and reflink cannot be used together!");
                         error = -EINVAL;
                         goto out_filestream_unmount;
                 }
         }

-Eric

  parent reply	other threads:[~2021-08-26 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 17:30 Bill O'Donnell
2021-08-26 18:09 ` Darrick J. Wong
2021-08-26 18:14   ` Bill O'Donnell
2021-08-26 18:16   ` Eric Sandeen [this message]
2021-08-26 22:08     ` Bill O'Donnell
2021-08-26 23:43       ` Eric Sandeen
2021-08-27 14:03         ` Bill O'Donnell
2021-08-27 14:18           ` Eric Sandeen
2021-08-27 14:25             ` Bill O'Donnell
2021-08-27 15:35               ` Eric Sandeen
2021-08-27 15:41                 ` Bill O'Donnell
2021-08-30 15:55   ` Bill O'Donnell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6ddf52a-0b85-665a-115e-106242b1af95@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bodonnel@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --subject='Re: [PATCH] xfs: dax: facilitate EXPERIMENTAL warning for dax=inode case' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).