From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ABD4C432BE for ; Thu, 26 Aug 2021 18:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0F7A60FC0 for ; Thu, 26 Aug 2021 18:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbhHZSRL (ORCPT ); Thu, 26 Aug 2021 14:17:11 -0400 Received: from sandeen.net ([63.231.237.45]:59540 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbhHZSRL (ORCPT ); Thu, 26 Aug 2021 14:17:11 -0400 Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id D749779F9; Thu, 26 Aug 2021 13:16:01 -0500 (CDT) To: "Darrick J. Wong" , Bill O'Donnell Cc: linux-xfs@vger.kernel.org References: <20210826173012.273932-1-bodonnel@redhat.com> <20210826180947.GL12640@magnolia> From: Eric Sandeen Subject: Re: [PATCH] xfs: dax: facilitate EXPERIMENTAL warning for dax=inode case Message-ID: Date: Thu, 26 Aug 2021 13:16:22 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210826180947.GL12640@magnolia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 8/26/21 1:09 PM, Darrick J. Wong wrote: > On Thu, Aug 26, 2021 at 12:30:12PM -0500, Bill O'Donnell wrote: >> @@ -1584,7 +1586,7 @@ xfs_fs_fill_super( >> if (xfs_has_crc(mp)) >> sb->s_flags |= SB_I_VERSION; >> >> - if (xfs_has_dax_always(mp)) { >> + if (xfs_has_dax_always(mp) || xfs_has_dax_inode(mp)) { > > Er... can't this be done without burning another feature bit by: > > if (xfs_has_dax_always(mp) || (!xfs_has_dax_always(mp) && > !xfs_has_dax_never(mp))) { > ... > xfs_warn(mp, "DAX IS EXPERIMENTAL"); > } changing this conditional in this way will also fail dax=inode mounts on reflink-capable (i.e. default) filesystems, no? - if (xfs_has_dax_always(mp)) { + if (xfs_has_dax_always(mp) || $NEW_DAX_INODE_TEST) { ... if (xfs_has_reflink(mp)) { xfs_alert(mp, "DAX and reflink cannot be used together!"); error = -EINVAL; goto out_filestream_unmount; } } -Eric